Skip to content

[SPARK-2479 (partial)][MLLIB] fix binary metrics unit tests #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,26 @@ package org.apache.spark.mllib.evaluation
import org.scalatest.FunSuite

import org.apache.spark.mllib.util.LocalSparkContext
import org.apache.spark.mllib.util.TestingUtils.DoubleWithAlmostEquals

class BinaryClassificationMetricsSuite extends FunSuite with LocalSparkContext {

// TODO: move utility functions to TestingUtils.

def elementsAlmostEqual(actual: Seq[Double], expected: Seq[Double]): Boolean = {
actual.zip(expected).forall { case (x1, x2) =>
x1.almostEquals(x2)
}
}

def elementsAlmostEqual(
actual: Seq[(Double, Double)],
expected: Seq[(Double, Double)])(implicit dummy: DummyImplicit): Boolean = {
actual.zip(expected).forall { case ((x1, y1), (x2, y2)) =>
x1.almostEquals(x2) && y1.almostEquals(y2)
}
}

test("binary evaluation metrics") {
val scoreAndLabels = sc.parallelize(
Seq((0.1, 0.0), (0.1, 1.0), (0.4, 0.0), (0.6, 0.0), (0.6, 1.0), (0.6, 1.0), (0.8, 1.0)), 2)
Expand All @@ -41,14 +59,14 @@ class BinaryClassificationMetricsSuite extends FunSuite with LocalSparkContext {
val prCurve = Seq((0.0, 1.0)) ++ pr
val f1 = pr.map { case (r, p) => 2.0 * (p * r) / (p + r) }
val f2 = pr.map { case (r, p) => 5.0 * (p * r) / (4.0 * p + r)}
assert(metrics.thresholds().collect().toSeq === threshold)
assert(metrics.roc().collect().toSeq === rocCurve)
assert(metrics.areaUnderROC() === AreaUnderCurve.of(rocCurve))
assert(metrics.pr().collect().toSeq === prCurve)
assert(metrics.areaUnderPR() === AreaUnderCurve.of(prCurve))
assert(metrics.fMeasureByThreshold().collect().toSeq === threshold.zip(f1))
assert(metrics.fMeasureByThreshold(2.0).collect().toSeq === threshold.zip(f2))
assert(metrics.precisionByThreshold().collect().toSeq === threshold.zip(precision))
assert(metrics.recallByThreshold().collect().toSeq === threshold.zip(recall))
assert(elementsAlmostEqual(metrics.thresholds().collect(), threshold))
assert(elementsAlmostEqual(metrics.roc().collect(), rocCurve))
assert(metrics.areaUnderROC().almostEquals(AreaUnderCurve.of(rocCurve)))
assert(elementsAlmostEqual(metrics.pr().collect(), prCurve))
assert(metrics.areaUnderPR().almostEquals(AreaUnderCurve.of(prCurve)))
assert(elementsAlmostEqual(metrics.fMeasureByThreshold().collect(), threshold.zip(f1)))
assert(elementsAlmostEqual(metrics.fMeasureByThreshold(2.0).collect(), threshold.zip(f2)))
assert(elementsAlmostEqual(metrics.precisionByThreshold().collect(), threshold.zip(precision)))
assert(elementsAlmostEqual(metrics.recallByThreshold().collect(), threshold.zip(recall)))
}
}