Skip to content

[SPARK-16193] [TESTS] Address flaky ExternalAppendOnlyMapSuite spilling tests #13896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

srowen
Copy link
Member

@srowen srowen commented Jun 24, 2016

What changes were proposed in this pull request?

Make spill tests wait until job has completed before returning the number of stages that spilled

How was this patch tested?

Existing Jenkins tests.

@srowen
Copy link
Member Author

srowen commented Jun 24, 2016

See also #9124 and CC @andrewor14

@andrewor14
Copy link
Contributor

LGTM

@SparkQA
Copy link

SparkQA commented Jun 25, 2016

Test build #61195 has finished for PR 13896 at commit bcc0297.

  • This patch fails from timeout after a configured wait of 250m.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 25, 2016

Test build #3132 has finished for PR 13896 at commit bcc0297.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 25, 2016

Test build #61225 has finished for PR 13896 at commit 1492280.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member Author

srowen commented Jun 25, 2016

Jenkins retest this please

@SparkQA
Copy link

SparkQA commented Jun 25, 2016

Test build #61227 has finished for PR 13896 at commit 1492280.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Jun 25, 2016
…g tests

## What changes were proposed in this pull request?

Make spill tests wait until job has completed before returning the number of stages that spilled

## How was this patch tested?

Existing Jenkins tests.

Author: Sean Owen <[email protected]>

Closes #13896 from srowen/SPARK-16193.

(cherry picked from commit e877415)
Signed-off-by: Sean Owen <[email protected]>
@srowen
Copy link
Member Author

srowen commented Jun 25, 2016

Merged to master/2.0/1.6

@asfgit asfgit closed this in e877415 Jun 25, 2016
asfgit pushed a commit that referenced this pull request Jun 25, 2016
…g tests

## What changes were proposed in this pull request?

Make spill tests wait until job has completed before returning the number of stages that spilled

## How was this patch tested?

Existing Jenkins tests.

Author: Sean Owen <[email protected]>

Closes #13896 from srowen/SPARK-16193.

(cherry picked from commit e877415)
Signed-off-by: Sean Owen <[email protected]>
zzcclp pushed a commit to zzcclp/spark that referenced this pull request Jun 27, 2016
…g tests

## What changes were proposed in this pull request?

Make spill tests wait until job has completed before returning the number of stages that spilled

## How was this patch tested?

Existing Jenkins tests.

Author: Sean Owen <[email protected]>

Closes apache#13896 from srowen/SPARK-16193.

(cherry picked from commit e877415)
Signed-off-by: Sean Owen <[email protected]>
(cherry picked from commit 60e095b)
@srowen srowen deleted the SPARK-16193 branch June 27, 2016 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants