Review feedback.

Author: ScrapCodes

.gitignore

@@ -45,3 +45,4 @@ dist/
 spark-*-bin.tar.gz
 unit-tests.log
 /lib/
+rat-results.txt

.rat-excludes

@@ -34,3 +34,6 @@ SparkMemberHandlers.scala
 sbt
 sbt-launch-lib.bash
 plugins.sbt
+work
+.*\.q
+golden

dev/rat.bash renamed to dev/check-license

@@ -17,6 +17,7 @@
 # limitations under the License.
 #
 
+
 acquire_rat_jar () {
 
   URL1="http://search.maven.org/remotecontent?filepath=org/apache/rat/apache-rat/${RAT_VERSION}/apache-rat-${RAT_VERSION}.jar"
@@ -47,3 +48,33 @@ acquire_rat_jar () {
     printf "Launching rat from ${JAR}\n"
   fi
 }
+
+# Go to the Spark project root directory
+FWDIR="$(cd `dirname $0`/..; pwd)"
+cd $FWDIR
+
+if test -x "$JAVA_HOME/bin/java"; then
+    declare java_cmd="$JAVA_HOME/bin/java"
+else 
+    declare java_cmd=java
+fi
+
+export RAT_VERSION=0.10
+export rat_jar=$FWDIR/lib/apache-rat-${RAT_VERSION}.jar
+mkdir -p $FWDIR/lib
+
+[[ -f "$rat_jar" ]] || acquire_rat_jar || {
+    echo "Download failed. Obtain the rat jar manually and place it at $rat_jar"
+    exit 1
+}
+
+$java_cmd -jar $rat_jar -E $FWDIR/.rat-excludes  -d $FWDIR > rat-results.txt
+
+ERRORS=$(cat rat-results.txt | grep -e "??")
+
+if test ! -z "$ERRORS"; then 
+    echo -e "Found errors: $ERRORS\n"
+    exit 1
+else 
+    echo -e "RAT checks passed."
+fi

dev/run-tests

@@ -34,23 +34,13 @@ else
 fi
 
 JAVA_VERSION=$($java_cmd -version 2>&1 | sed 's/java version "\(.*\)\.\(.*\)\..*"/\1\2/; 1q')
-[ "$JAVA_VERSION" -ge 18 ] && echo "" || echo "[Warn] Java 8 tests will not run, because JDK version is < 1.8."
-
-export RAT_VERSION=0.10
-export rat_jar=$FWDIR/lib/apache-rat-${RAT_VERSION}.jar
-mkdir -p $FWDIR/lib
-
-source $FWDIR/dev/rat.bash
+[ "$JAVA_VERSION" -ge 18 ] && echo "" || echo "[Warn] Java 8 tests will not run because JDK version is < 1.8."
 
 echo "========================================================================="
 echo "Running Apache RAT checks"
 echo "========================================================================="
-[[ -f "$rat_jar" ]] || acquire_rat_jar || {
-    echo "Download failed. Obtain the rat jar manually and place it at $rat_jar"
-    exit 1
-}
 
-$java_cmd -jar $rat_jar -E $FWDIR/.rat-excludes  -d $FWDIR
+dev/check-license
 
 echo "========================================================================="
 echo "Running Scala style checks"