Skip to content

Commit d2e4e23

Browse files
author
Andrew Or
committed
One more
1 parent 202d48e commit d2e4e23

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,9 +122,7 @@ private UnsafeExternalSorter(
122122
// Use getSizeAsKb (not bytes) to maintain backwards compatibility for units
123123
// this.fileBufferSizeBytes = (int) conf.getSizeAsKb("spark.shuffle.file.buffer", "32k") * 1024;
124124
this.fileBufferSizeBytes = 32 * 1024;
125-
// TODO: metrics tracking + integration with shuffle write metrics
126-
// need to connect the write metrics to task metrics so we count the spill IO somewhere.
127-
this.writeMetrics = new ShuffleWriteMetrics();
125+
this.writeMetrics = taskContext.taskMetrics().registerShuffleWriteMetrics();
128126

129127
if (existingInMemorySorter == null) {
130128
this.inMemSorter = new UnsafeInMemorySorter(

0 commit comments

Comments
 (0)