Skip to content

Commit a581f3f

Browse files
author
Nathan Kronenfeld
committed
Change Accumulators to private[spark] instead of adding mima exclude to get around false positive in mima tests
1 parent b6c2180 commit a581f3f

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

core/src/main/scala/org/apache/spark/Accumulators.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ object AccumulatorParam {
279279

280280
// TODO: The multi-thread support in accumulators is kind of lame; check
281281
// if there's a more intuitive way of doing it right
282-
private object Accumulators {
282+
private[spark] object Accumulators {
283283
// TODO: Use soft references? => need to make readObject work properly then
284284
val originals = Map[Long, Accumulable[_, _]]()
285285
val localAccums = new ThreadLocal[Map[Long, Accumulable[_, _]]]() {

project/MimaExcludes.scala

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,6 @@ object MimaExcludes {
5353
"org.apache.spark.mllib.linalg.Matrices.randn"),
5454
ProblemFilters.exclude[MissingMethodProblem](
5555
"org.apache.spark.mllib.linalg.Matrices.rand")
56-
) ++ Seq(
57-
// SPARK-4772
58-
ProblemFilters.exclude[IncompatibleResultTypeProblem](
59-
"org.apache.spark.Accumulators.localAccums")
6056
)
6157

6258
case v if v.startsWith("1.2") =>

0 commit comments

Comments
 (0)