[SPARK-4057] Use -agentlib instead of -Xdebug in sbt-launch-lib.bash for debugging

sarutak · pwendell · commit 938dc141ee44 · 2014-11-29T20:14:14.000-05:00
In -launch-lib.bash, -Xdebug option is used for debugging. We should use -agentlib option for Java 6+. Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp> Closes #2904 from sarutak/SPARK-4057 and squashes the following commits: 39b5320 [Kousuke Saruta] Merge branch 'master' of git://git.apache.org/spark into SPARK-4057 26b4af8 [Kousuke Saruta] Improved java option for debugging
diff --git a/sbt/sbt-launch-lib.bash b/sbt/sbt-launch-lib.bash
@@ -104,7 +104,7 @@ addResidual () {
   residual_args=( "${residual_args[@]}" "$1" )
 }
 addDebugger () {
-  addJava "-Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=$1"
+  addJava "-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=$1"
 }
 
 # a ham-fisted attempt to move some memory settings in concert

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ addResidual () {`
`104`	`104`	`residual_args=( "${residual_args[@]}" "$1" )`
`105`	`105`	`}`
`106`	`106`	`addDebugger () {`
`107`		`- addJava "-Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=$1"`
	`107`	`+ addJava "-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=$1"`
`108`	`108`	`}`
`109`	`109`
`110`	`110`	`# a ham-fisted attempt to move some memory settings in concert`