Skip to content

Commit 4c18c29

Browse files
committed
remove setAs[T] and null judge
1 parent 1614493 commit 4c18c29

File tree

2 files changed

+0
-9
lines changed

2 files changed

+0
-9
lines changed

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Row.scala

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,6 @@ trait MutableRow extends Row {
9999
def setByte(ordinal: Int, value: Byte)
100100
def setFloat(ordinal: Int, value: Float)
101101
def setString(ordinal: Int, value: String)
102-
def setAs[T](ordinal: Int, value: T) = update(ordinal, value)
103102
}
104103

105104
/**
@@ -184,11 +183,6 @@ class GenericRow(protected[sql] val values: Array[Any]) extends Row {
184183
values(i).asInstanceOf[String]
185184
}
186185

187-
override def getAs[T](i: Int): T = {
188-
if (values(i) == null) sys.error("Failed to check null bit for generic value.")
189-
values(i).asInstanceOf[T]
190-
}
191-
192186
// Custom hashCode function that matches the efficient code generated version.
193187
override def hashCode(): Int = {
194188
var result: Int = 37
@@ -232,7 +226,6 @@ class GenericMutableRow(size: Int) extends GenericRow(size) with MutableRow {
232226
override def setInt(ordinal: Int, value: Int): Unit = { values(ordinal) = value }
233227
override def setLong(ordinal: Int, value: Long): Unit = { values(ordinal) = value }
234228
override def setString(ordinal: Int, value: String): Unit = { values(ordinal) = value }
235-
override def setAs[T](ordinal: Int, value: T): Unit = { values(ordinal) = value }
236229

237230
override def setNullAt(i: Int): Unit = { values(i) = null }
238231

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SpecificRow.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -307,8 +307,6 @@ final class SpecificMutableRow(val values: Array[MutableValue]) extends MutableR
307307
values(i).asInstanceOf[MutableByte].value
308308
}
309309

310-
override def setAs[T](ordinal: Int, value: T): Unit = update(ordinal, value)
311-
312310
override def getAs[T](i: Int): T = {
313311
values(i).asInstanceOf[MutableAny].value.asInstanceOf[T]
314312
}

0 commit comments

Comments
 (0)