Skip to content

Commit 341e708

Browse files
fix bug in test
1 parent 40fed21 commit 341e708

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,7 @@ abstract class BinaryArithmetic extends BinaryExpression {
7878

7979
override lazy val resolved =
8080
left.resolved && right.resolved &&
81-
left.dataType == right.dataType &&
82-
!DecimalType.isFixed(left.dataType)
81+
left.dataType == right.dataType
8382

8483
def dataType: DataType = {
8584
if (!resolved) {

sql/core/src/main/scala/org/apache/spark/sql/execution/Aggregate.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,7 @@ case class DistinctAggregate(
407407
val value = ae.eval(currentRow)
408408

409409
if (ae.distinct) {
410-
if (!seens(idx).contains(value)) {
410+
if (value != null && !seens(idx).contains(value)) {
411411
ae.iterate(value, buffer)
412412
seens(idx).add(value)
413413
}
@@ -434,7 +434,7 @@ case class DistinctAggregate(
434434
val value = ae.eval(currentRow)
435435

436436
if (ae.distinct) {
437-
if (!inputBufferSeens.seens(idx).contains(value)) {
437+
if (value != null && !inputBufferSeens.seens(idx).contains(value)) {
438438
ae.iterate(value, inputBufferSeens.buffer)
439439
inputBufferSeens.seens(idx).add(value)
440440
}

0 commit comments

Comments
 (0)