Skip to content

Commit 332422f

Browse files
committed
Code review feedback
1 parent ca9eeee commit 332422f

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

core/src/main/scala/org/apache/spark/network/netty/FileServer.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ class FileServer(pResolver: PathResolver, private var port: Int) extends Logging
6464
case e: InterruptedException =>
6565
logError("File server start got interrupted", e)
6666
}
67+
// NOTE: bootstrap is shutdown in stop()
6768
}
6869
}
6970
blockingThread.setDaemon(true)

core/src/main/scala/org/apache/spark/network/netty/FileServerHandler.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class FileServerHandler(pResolver: PathResolver)
2929
extends SimpleChannelInboundHandler[String] with Logging {
3030

3131
override def channelRead0(ctx: ChannelHandlerContext, blockIdString: String): Unit = {
32-
val blockId: BlockId = BlockId.apply(blockIdString)
32+
val blockId: BlockId = BlockId(blockIdString)
3333
val fileSegment: FileSegment = pResolver.getBlockLocation(blockId)
3434
if (fileSegment == null) {
3535
return

0 commit comments

Comments
 (0)