Skip to content

Commit 052e658

Browse files
KaiXinXiaoLeipwendell
authored andcommitted
Delete unnecessary function
when building spark by sbt, the function “runAlternateBoot" in sbt/sbt-launch-lib.bash is not used. And this function is not used by spark code. So I think this function is not necessary. And the option of "sbt.boot.properties" can be configured in the command line when building spark, eg: sbt/sbt assembly -Dsbt.boot.properties=$bootpropsfile. The file from https://github.com/sbt/sbt-launcher-package is changed. And the function “runAlternateBoot" is deleted in upstream project. I think spark project should delete this function in file sbt/sbt-launch-lib.bash. Thanks. Author: KaiXinXiaoLei <[email protected]> Closes #3224 from KaiXinXiaoLei/deleteFunction and squashes the following commits: e8eac49 [KaiXinXiaoLei] Delete blank lines. efe36d4 [KaiXinXiaoLei] Delete unnecessary function
1 parent 5b99bf2 commit 052e658

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

sbt/sbt-launch-lib.bash

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -186,10 +186,3 @@ run() {
186186
"${sbt_commands[@]}" \
187187
"${residual_args[@]}"
188188
}
189-
190-
runAlternateBoot() {
191-
local bootpropsfile="$1"
192-
shift
193-
addJava "-Dsbt.boot.properties=$bootpropsfile"
194-
run $@
195-
}

0 commit comments

Comments
 (0)