Skip to content

Commit 048e989

Browse files
felixcheungFelix Cheung
authored andcommitted
[SPARK-20543][SPARKR][FOLLOWUP] Don't skip tests on AppVeyor
## What changes were proposed in this pull request? add environment ## How was this patch tested? wait for appveyor run Author: Felix Cheung <[email protected]> Closes #17878 from felixcheung/appveyorrcran. (cherry picked from commit 7087e01) Signed-off-by: Felix Cheung <[email protected]>
1 parent 423a786 commit 048e989

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

R/pkg/inst/tests/testthat/test_sparkSQL.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3126,7 +3126,7 @@ compare_list <- function(list1, list2) {
31263126

31273127
# This should always be the **very last test** in this test file.
31283128
test_that("No extra files are created in SPARK_HOME by starting session and making calls", {
3129-
skip_on_cran()
3129+
skip_on_cran() # skip because when run from R CMD check SPARK_HOME is not the current directory
31303130

31313131
# Check that it is not creating any extra file.
31323132
# Does not check the tempdir which would be cleaned up after.

appveyor.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,9 @@ install:
4848
build_script:
4949
- cmd: mvn -DskipTests -Psparkr -Phive -Phive-thriftserver package
5050

51+
environment:
52+
NOT_CRAN: true
53+
5154
test_script:
5255
- cmd: .\bin\spark-submit2.cmd --conf spark.hadoop.fs.defaultFS="file:///" R\pkg\tests\run-all.R
5356

@@ -56,4 +59,3 @@ notifications:
5659
on_build_success: false
5760
on_build_failure: false
5861
on_build_status_changed: false
59-

0 commit comments

Comments
 (0)