Skip to content

Commit ff1f6a2

Browse files
authored
Drop support for 3.7 and fix tests (#356)
1 parent 1ce6910 commit ff1f6a2

File tree

16 files changed

+1658
-1422
lines changed

16 files changed

+1658
-1422
lines changed

.github/workflows/CI.yaml

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ jobs:
125125
runs-on: ubuntu-latest
126126
strategy:
127127
matrix: # may support pypy in the future
128-
python-version: [ "3.7-slim", "3.8-slim", "3.9-slim", "3.10-slim", "3.11-slim" ]
128+
python-version: [ "3.8-slim", "3.9-slim", "3.10-slim", "3.11-slim" ]
129129
fail-fast: false
130130
env:
131131
BASE_PYTHON_IMAGE: ${{ matrix.python-version }}
@@ -157,7 +157,7 @@ jobs:
157157
timeout-minutes: 20
158158
strategy:
159159
matrix:
160-
python-version: [ "3.7", "3.8", "3.9", "3.10", "3.11" ]
160+
python-version: [ "3.8", "3.9", "3.10", "3.11" ]
161161
test-path: ${{fromJson(needs.prep-plugin-and-unit-tests.outputs.matrix)}}
162162
fail-fast: false
163163
env:
@@ -167,6 +167,15 @@ jobs:
167167
uses: actions/checkout@v3
168168
with:
169169
submodules: true
170+
- name: Install docker-compose
171+
shell: bash
172+
if: runner.os != 'Windows'
173+
run: |
174+
if ! command docker-compose 2>&1 > /dev/null; then
175+
echo "Installing docker-compose"
176+
sudo curl -L "https://github.com/docker/compose/releases/download/1.29.2/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose
177+
sudo chmod +x /usr/local/bin/docker-compose
178+
fi
170179
- name: Pull SkyWalking Python agent base image
171180
uses: actions/download-artifact@v3
172181
with:
@@ -195,7 +204,7 @@ jobs:
195204
timeout-minutes: 10
196205
strategy:
197206
matrix:
198-
python-image-variant: [ "3.7-slim", "3.8-slim", "3.9-slim", "3.10-slim", "3.11-slim" ]
207+
python-image-variant: [ "3.8-slim", "3.9-slim", "3.10-slim", "3.11-slim" ]
199208
fail-fast: false
200209
env:
201210
BASE_PYTHON_IMAGE: ${{ matrix.python-image-variant }}
@@ -226,7 +235,7 @@ jobs:
226235
timeout-minutes: 20
227236
strategy:
228237
matrix:
229-
python-image-variant: [ "3.7-slim", "3.8-slim", "3.9-slim", "3.10-slim", "3.11-slim" ]
238+
python-image-variant: [ "3.8-slim", "3.9-slim", "3.10-slim", "3.11-slim" ]
230239
case:
231240
- name: gRPC-single-process
232241
path: tests/e2e/case/grpc/single/e2e.yaml
@@ -264,7 +273,7 @@ jobs:
264273
- name: Load docker images
265274
run: find docker-images -name "*.tar" -exec docker load -i {} \;
266275
- name: Run E2E Tests
267-
uses: apache/skywalking-infra-e2e@2f20482135ba3a933bc0bb48c41f538ad1aa3048
276+
uses: apache/skywalking-infra-e2e@cf589b4a0b9f8e6f436f78e9cfd94a1ee5494180
268277
with:
269278
log-dir: /tmp/e2e-logs
270279
e2e-file: ${{ matrix.case.path }}

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ license: clean
9797
.PHONY: test
9898
test: env
9999
sudo apt-get -y install jq
100-
docker build --build-arg BASE_PYTHON_IMAGE=3.7-slim -t apache/skywalking-python-agent:latest-plugin --no-cache . -f tests/plugin/Dockerfile.plugin
100+
docker build --build-arg BASE_PYTHON_IMAGE=3.8-slim -t apache/skywalking-python-agent:latest-plugin --no-cache . -f tests/plugin/Dockerfile.plugin
101101
poetry run pytest -v $(bash tests/gather_test_paths.sh)
102102

103103
.PHONY: package

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131

3232
## Installation Requirements
3333

34-
SkyWalking Python Agent requires [Apache SkyWalking 8.0+](https://skywalking.apache.org/downloads/#SkyWalkingAPM) and Python 3.7+.
34+
SkyWalking Python Agent requires [Apache SkyWalking 8.0+](https://skywalking.apache.org/downloads/#SkyWalkingAPM) and Python 3.8+.
3535

3636
> If you would like to try out the latest features that are not released yet, please refer to this [guide](docs/en/setup/faq/How-to-build-from-sources.md) to build from sources.
3737

docker/Makefile

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,36 +21,30 @@ D := docker
2121

2222
P := grpc http kafka
2323

24-
TARGETS := py3.7 py3.8 py3.9 py3.10 py3.7-slim py3.8-slim py3.9-slim py3.10-slim
24+
TARGETS := py3.8 py3.9 py3.10 py3.8-slim py3.9-slim py3.10-slim
2525

26-
py3.7: BASE_PYTHON_IMAGE = python:3.7
2726
py3.8: BASE_PYTHON_IMAGE = python:3.8
2827
py3.9: BASE_PYTHON_IMAGE = python:3.9
2928
py3.10: BASE_PYTHON_IMAGE = python:3.10
3029
py3.11: BASE_PYTHON_IMAGE = python:3.11
31-
py3.7-slim: BASE_PYTHON_IMAGE = python:3.7-slim
3230
py3.8-slim: BASE_PYTHON_IMAGE = python:3.8-slim
3331
py3.9-slim: BASE_PYTHON_IMAGE = python:3.9-slim
3432
py3.10-slim: BASE_PYTHON_IMAGE = python:3.10-slim
3533
py3.11-slim: BASE_PYTHON_IMAGE = python:3.11-slim
3634

37-
push-py3.7: BASE_PYTHON_IMAGE = python:3.7
3835
push-py3.8: BASE_PYTHON_IMAGE = python:3.8
3936
push-py3.9: BASE_PYTHON_IMAGE = python:3.9
4037
push-py3.10: BASE_PYTHON_IMAGE = python:3.10
4138
push-py3.11: BASE_PYTHON_IMAGE = python:3.11
42-
push-py3.7-slim: BASE_PYTHON_IMAGE = python:3.7-slim
4339
push-py3.8-slim: BASE_PYTHON_IMAGE = python:3.8-slim
4440
push-py3.9-slim: BASE_PYTHON_IMAGE = python:3.9-slim
4541
push-py3.10-slim: BASE_PYTHON_IMAGE = python:3.10-slim
4642
push-py3.11-slim: BASE_PYTHON_IMAGE = python:3.11-slim
4743

48-
push-py3.7: BUILDER_PYTHON_IMAGE = python:3.7
4944
push-py3.8: BUILDER_PYTHON_IMAGE = python:3.8
5045
push-py3.9: BUILDER_PYTHON_IMAGE = python:3.9
5146
push-py3.10: BUILDER_PYTHON_IMAGE = python:3.10
5247
push-py3.11: BUILDER_PYTHON_IMAGE = python:3.11
53-
push-py3.7-slim: BUILDER_PYTHON_IMAGE = python:3.7
5448
push-py3.8-slim: BUILDER_PYTHON_IMAGE = python:3.8
5549
push-py3.9-slim: BUILDER_PYTHON_IMAGE = python:3.9
5650
push-py3.10-slim: BUILDER_PYTHON_IMAGE = python:3.10

docs/en/contribution/Developer.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ Once you have `make` ready, run `make env`, this will automatically install the
2828
Note: Make sure you have `python3` aliased to `python` available on Windows computers instead of pointing to the Microsoft app store.
2929

3030
### Switching between Multiple Python Versions
31-
Do not develop/test on Python < 3.7, since Poetry and some other functionalities we implement rely on Python 3.7+
31+
Do not develop/test on Python < 3.8, since Poetry and some other functionalities we implement rely on Python 3.8+
3232

3333
If you would like to test on multiple Python versions, run the following to switch and recreate virtual environment:
3434
#### Without Python Version Tools
@@ -48,4 +48,4 @@ Or try: `virtualenvs.prefer-active-python`, which is an experimental poetry feat
4848
automatically follow environment.
4949

5050
# Next
51-
Refer to the [Plugin Development Guide](How-to-develop-plugin.md) to learn how to build a new plugin for a library.
51+
Refer to the [Plugin Development Guide](How-to-develop-plugin.md) to learn how to build a new plugin for a library.

docs/en/setup/Container.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
source**
55

66
This image hosts the SkyWalking Python agent package on top of official Python base images (full & slim) providing support from
7-
Python 3.7 - 3.11.
7+
Python 3.8 - 3.11.
88

99
## How to use this image
1010

docs/en/setup/Installation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
## Installation
22

3-
**SkyWalking Python agent requires SkyWalking 8.0+ and Python 3.7+**
3+
**SkyWalking Python agent requires SkyWalking 8.0+ and Python 3.8+**
44

55
You can install the SkyWalking Python agent via various ways described next.
66

docs/en/setup/Plugins.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ or a limitation of SkyWalking auto-instrumentation (welcome to contribute!)
1313
### Plugin Support Table
1414
| Library | Python Version - Lib Version | Plugin Name |
1515
| :--- | :--- | :--- |
16-
| [aiohttp](https://docs.aiohttp.org) | Python >=3.7 - ['3.7.*']; | `sw_aiohttp` |
16+
| [aiohttp](https://docs.aiohttp.org) | Python >=3.8 - NOT SUPPORTED YET; | `sw_aiohttp` |
1717
| [aioredis](https://aioredis.readthedocs.io/) | Python >=3.7 - ['2.0.*']; | `sw_aioredis` |
1818
| [aiormq](https://pypi.org/project/aiormq/) | Python >=3.7 - ['6.3', '6.4']; | `sw_aiormq` |
1919
| [amqp](https://pypi.org/project/amqp/) | Python >=3.7 - ['2.6.1']; | `sw_amqp` |

docs/en/setup/faq/How-to-build-from-sources.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
**Download the source tar from the [official website](http://skywalking.apache.org/downloads/),
44
and run the following commands to build from source**
55

6-
**Make sure you have Python 3.7+ and the `python3` command available**
6+
**Make sure you have Python 3.8+ and the `python3` command available**
77

88
```shell
99
$ tar -zxf skywalking-python-src-<version>.tgz

0 commit comments

Comments
 (0)