Skip to content

Commit 716f038

Browse files
committed
chore: fixed discussions notification target in .asf.yaml and syncd pull request template since "squash and merge" is enabled
1 parent 88cfebf commit 716f038

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.asf.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,4 +34,5 @@ notifications:
3434
pullrequests: [email protected]
3535
3636
37+
discussions: [email protected]
3738
jira_options: link label worklog

.github/pull_request_template.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,14 @@ Following this checklist to help us incorporate your contribution quickly and ea
88
- [ ] Make sure there is a [GitHub issue](https://github.com/apache/shiro/issues) filed
99
for the change (usually before you start working on it). Trivial changes like typos do not
1010
require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
11-
- [ ] Each commit in the pull request should have a meaningful subject line and body.
1211
- [ ] Format the pull request title like `[#XXX] - Fixes bug in SessionManager`,
1312
where you replace `#XXX` with the appropriate GitHub issue. Best practice
1413
is to use the GitHub issue title in the pull request title and in the first line of the commit message.
1514
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
1615
- [ ] add `fixes #XXX` if merging the PR should close a related issue.
1716
- [ ] Run `mvn verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
18-
- [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
1917
- [ ] Committers: Make sure a milestone is set on the PR
18+
- [ ] Committers: Use "Squash and Merge" to combine all commits into one when merging a PR when appropriate.
2019

2120
Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
2221
In this case, just format the pull request title like `[DOC] - Add javadoc in SessionManager`.

0 commit comments

Comments
 (0)