[MPMD-379] Upgrade to use PMD 7.0.0 by default (#144)

Merged pull request #144 from mkolesnikov:feature/MPMD-379_pmd_7

Author: adangel

pom.xml

@@ -28,7 +28,7 @@ under the License.
   </parent>
 
   <artifactId>maven-pmd-plugin</artifactId>
-  <version>3.21.3-SNAPSHOT</version>
+  <version>3.22.0-SNAPSHOT</version>
   <packaging>maven-plugin</packaging>
 
   <name>Apache Maven PMD Plugin</name>
@@ -83,7 +83,7 @@ under the License.
   <properties>
     <mavenVersion>3.2.5</mavenVersion>
     <javaVersion>8</javaVersion>
-    <pmdVersion>6.55.0</pmdVersion>
+    <pmdVersion>7.0.0</pmdVersion>
     <slf4jVersion>1.7.36</slf4jVersion>
     <aetherVersion>1.0.0.v20140518</aetherVersion>
     <doxiaVersion>1.12.0</doxiaVersion>
@@ -187,12 +187,6 @@ under the License.
       <artifactId>slf4j-api</artifactId>
       <version>${slf4jVersion}</version>
     </dependency>
-    <!-- Support logging of PMD through slf4j. See also MPMD-244 -->
-    <dependency>
-      <groupId>org.slf4j</groupId>
-      <artifactId>jul-to-slf4j</artifactId>
-      <version>${slf4jVersion}</version>
-    </dependency>
 
     <!-- doxia -->
     <dependency>

src/it/MPMD-219-pmd-processing-error/verify.groovy

@@ -20,5 +20,5 @@
 File buildLog = new File( basedir, 'build.log' )
 assert buildLog.exists()
 assert buildLog.text.contains( "PMD processing errors" )
-assert buildLog.text.contains( "Error while parsing" )
+assert buildLog.text.contains( "ParseException: Parse exception in file" )
 assert buildLog.text.contains( "BrokenFile.java" )

src/it/MPMD-243-excludeFromFailureFile/config/ruleset.xml

@@ -26,5 +26,5 @@ under the License.
     MPMD-243
   </description>
 
-  <rule ref="rulesets/java/imports.xml/TooManyStaticImports"/>
+  <rule ref="category/java/codestyle.xml/TooManyStaticImports"/>
 </ruleset>

src/it/MPMD-244-logging/logging-disabled/pom.xml

@@ -45,7 +45,6 @@ under the License.
         <version>@project.version@</version>
         <configuration>
           <skipPmdError>true</skipPmdError>
-          <showPmdLog>true</showPmdLog>
         </configuration>
         <executions>
           <execution>

src/it/MPMD-244-logging/logging-enabled/pom.xml

@@ -36,7 +36,6 @@ under the License.
   </properties>
 
   <modules>
-    <module>logging-disabled</module>
     <module>logging-enabled</module>
   </modules>
 </project>

src/it/MPMD-244-logging/pom.xml

@@ -20,12 +20,15 @@
 File buildLog = new File( basedir, 'build.log' )
 assert buildLog.exists()
 assert buildLog.text.contains( "PMD processing errors" )
-assert buildLog.text.contains( "Error while parsing" )
+assert buildLog.text.contains( "ParseException: Parse exception" )
+assert buildLog.text.contains( "at line 24, column 5: Encountered" )
 
-String disabledPath = new File( basedir, 'logging-disabled/src/main/java/BrokenFile.java' ).getCanonicalPath()
 String enabledPath = new File( basedir, 'logging-enabled/src/main/java/BrokenFile.java' ).getCanonicalPath()
 
-// logging disabled: the pmd exception is only output through the processing error reporting (since MPMD-246)
-assert 1 == buildLog.text.count( "net.sourceforge.pmd.PMDException: Error while parsing ${disabledPath}" )
-// logging enabled: the pmd exception is output twice: through the processing error reporting (since MPMD-246) and through PMD's own logging
-assert 2 == buildLog.text.count( "net.sourceforge.pmd.PMDException: Error while parsing ${enabledPath}" )
+// logging enabled: the pmd exception is still output only once: through the processing error reporting (since MPMD-246) - PMD 7 doesn't log the processing error additionally
+assert 1 == buildLog.text.count( "${enabledPath}: ParseException: Parse exception in" )
+
+// build.log contains the logging from the two PMD executions
+// only one execution has logging enabled, so we expect only one log output
+assert 1 == buildLog.text.count( "[DEBUG] Rules loaded from" )
+// with --debug switch or -X the logging is always enabled and can't be disabled , because PMD 7 switched to slf4j

src/it/MPMD-244-logging/verify.groovy

@@ -15,5 +15,6 @@
 # specific language governing permissions and limitations
 # under the License.
 
+invoker.debug = true
 invoker.goals = clean compile pmd:pmd
 invoker.maven.version = 3.1.0+

src/it/MPMD-258-multiple-executions/invoker.properties

@@ -21,7 +21,9 @@ File buildLog = new File( basedir, 'build.log' )
 assert buildLog.exists()
 
 // we have 2 modules and for each module this should be output once
+// note: this is only logged in debug mode by net.sourceforge.pmd.cache.FileAnalysisCache
 assert 2 == buildLog.text.count( "Analysis cache created" )
 
 // since we are running clean pmd:pmd, the cache is always created, never updated
+// note: this is only logged in debug mode by net.sourceforge.pmd.cache.FileAnalysisCache
 assert 0 == buildLog.text.count( "Analysis cache updated" )

src/it/MPMD-258-multiple-executions/verify.groovy

@@ -19,4 +19,4 @@
 
 File buildLog = new File( basedir, 'build.log' )
 assert buildLog.exists()
-assert buildLog.text.contains( "[WARNING] Use Rule name category/java/codestyle.xml/ControlStatementBraces instead of the deprecated" )
+assert buildLog.text.contains( "Use Rule name category/java/codestyle.xml/ControlStatementBraces instead of the deprecated Rule name" )