Skip to content

Commit f7bfa53

Browse files
committed
Fix empty --patch-module command line entries
When using an exclude filter, it is possible that the plugin creates javadoc --patch-module command line options, that do not actually have a value. This changes skips such empty entries.
1 parent 72c8ee5 commit f7bfa53

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4594,12 +4594,14 @@ private void addJavadocOptions(
45944594
}
45954595

45964596
for (Entry<String, Collection<Path>> entry : patchModules.entrySet()) {
4597-
addArgIfNotEmpty(
4598-
arguments,
4599-
"--patch-module",
4600-
entry.getKey() + '=' + JavadocUtil.quotedPathArgument(getSourcePath(entry.getValue())),
4601-
false,
4602-
false);
4597+
if (!entry.getValue().isEmpty()) {
4598+
addArgIfNotEmpty(
4599+
arguments,
4600+
"--patch-module",
4601+
entry.getKey() + '=' + JavadocUtil.quotedPathArgument(getSourcePath(entry.getValue())),
4602+
false,
4603+
false);
4604+
}
46034605
}
46044606

46054607
if (doclet != null && !doclet.isEmpty()) {

0 commit comments

Comments
 (0)