Skip to content

Commit 1dbeb5e

Browse files
authored
feat: update some code (#28)
Signed-off-by: yuluo-yx <[email protected]>
1 parent ed20c5c commit 1dbeb5e

File tree

8 files changed

+97
-176
lines changed

8 files changed

+97
-176
lines changed

.editorconfig

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# http://editorconfig.org
2+
3+
root = true
4+
5+
[*]
6+
charset = utf-8
7+
end_of_line = lf
8+
insert_final_newline = true
9+
indent_style = space
10+
indent_size = 2
11+
max_line_length = 80
12+
trim_trailing_whitespace = true
13+
14+
[Makefile]
15+
indent_style = tab

.gitattributes

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# Auto detect text files and perform LF normalization
2+
* text=auto
3+
* text eol=lf
4+
5+
# Binary files - treat as binary, no line ending conversion
6+
*.png binary
7+
*.jpg binary
8+
*.jpeg binary
9+
*.gif binary
10+
*.ico binary
11+
*.svg binary

internal/banner/embed.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ package banner
1919

2020
import (
2121
"embed"
22+
"fmt"
2223
"os"
2324
"strconv"
2425
"text/template"
@@ -27,6 +28,14 @@ import (
2728
bannertypes "hertzbeat.apache.org/hertzbeat-collector-go/internal/collector/common/types/err"
2829
)
2930

31+
const (
32+
// ANSI color codes
33+
ColorReset = "\033[0m"
34+
ColorPurple = "\033[35m"
35+
ColorGreen = "\033[32m"
36+
ColorYellow = "\033[33m"
37+
)
38+
3039
//go:embed banner.txt
3140
var EmbedLogo embed.FS
3241

@@ -74,7 +83,11 @@ func (r *Runner) PrintBanner(appName, port string) error {
7483
Pid: strconv.Itoa(os.Getpid()),
7584
}
7685

86+
// Print banner with color
87+
fmt.Print(ColorPurple)
7788
err = tmpl.Execute(os.Stdout, vars)
89+
fmt.Print(ColorReset)
90+
7891
if err != nil {
7992
r.Logger.Error(bannertypes.BannerPrintExecuteError, "template parse error", "error", err)
8093
return err

internal/util/logger/logger.go

Lines changed: 54 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -18,64 +18,65 @@
1818
package logger
1919

2020
import (
21-
"io"
22-
"os"
23-
24-
"github.com/go-logr/logr"
25-
"github.com/go-logr/zapr"
26-
"go.uber.org/zap"
27-
"go.uber.org/zap/zapcore"
28-
"hertzbeat.apache.org/hertzbeat-collector-go/internal/collector/common/types/logger"
21+
"io"
22+
"os"
23+
24+
"github.com/go-logr/logr"
25+
"github.com/go-logr/zapr"
26+
"go.uber.org/zap"
27+
"go.uber.org/zap/zapcore"
28+
29+
"hertzbeat.apache.org/hertzbeat-collector-go/internal/collector/common/types/logger"
2930
)
3031

3132
type Logger struct {
32-
logr.Logger
33-
out io.Writer
34-
logging *logger.HertzBeatLogging
35-
sugaredLogger *zap.SugaredLogger
33+
logr.Logger
34+
out io.Writer
35+
logging *logger.HertzBeatLogging
36+
sugaredLogger *zap.SugaredLogger
3637
}
3738

3839
func NewLogger(w io.Writer, logging *logger.HertzBeatLogging) Logger {
3940

40-
logger := initZapLogger(w, logging, logging.Level[logger.LogComponentHertzbeatDefault])
41+
logger := initZapLogger(w, logging, logging.Level[logger.LogComponentHertzbeatDefault])
4142

42-
return Logger{
43-
Logger: zapr.NewLogger(logger),
44-
out: w,
45-
logging: logging,
46-
sugaredLogger: logger.Sugar(),
47-
}
43+
return Logger{
44+
Logger: zapr.NewLogger(logger),
45+
out: w,
46+
logging: logging,
47+
sugaredLogger: logger.Sugar(),
48+
}
4849
}
4950

5051
func FileLogger(file, name string, level logger.LogLevel) Logger {
5152

52-
writer, err := os.OpenFile(file, os.O_WRONLY, 0o666)
53-
if err != nil {
54-
panic(err)
55-
}
53+
writer, err := os.OpenFile(file, os.O_WRONLY, 0o666)
54+
if err != nil {
55+
panic(err)
56+
}
5657

57-
logging := logger.DefaultHertzbeatLogging()
58-
logger := initZapLogger(writer, logging, level)
58+
logging := logger.DefaultHertzbeatLogging()
59+
logger := initZapLogger(writer, logging, level)
5960

60-
return Logger{
61-
Logger: zapr.NewLogger(logger).WithName(name),
62-
logging: logging,
63-
out: writer,
64-
sugaredLogger: logger.Sugar(),
65-
}
61+
return Logger{
62+
Logger: zapr.NewLogger(logger).WithName(name),
63+
logging: logging,
64+
out: writer,
65+
sugaredLogger: logger.Sugar(),
66+
}
6667
}
6768

6869
func DefaultLogger(out io.Writer, level logger.LogLevel) Logger {
6970

70-
logging := logger.DefaultHertzbeatLogging()
71-
logger := initZapLogger(out, logging, level)
71+
logging := logger.DefaultHertzbeatLogging()
72+
logger := initZapLogger(out, logging, level)
7273

73-
return Logger{
74-
Logger: zapr.NewLogger(logger),
75-
out: out,
76-
logging: logging,
77-
sugaredLogger: logger.Sugar(),
78-
}
74+
return Logger{
75+
Logger: zapr.NewLogger(logger),
76+
out: out,
77+
logging: logging,
78+
sugaredLogger: logger.Sugar(),
79+
}
7980
}
8081

8182
// WithName returns a new Logger instance with the specified name element added
@@ -85,23 +86,23 @@ func DefaultLogger(out io.Writer, level logger.LogLevel) Logger {
8586
// more information).
8687
func (l Logger) WithName(name string) Logger {
8788

88-
logLevel := l.logging.Level[logger.HertzbeatLogComponent(name)]
89-
logger := initZapLogger(l.out, l.logging, logLevel)
89+
logLevel := l.logging.Level[logger.HertzbeatLogComponent(name)]
90+
logger := initZapLogger(l.out, l.logging, logLevel)
9091

91-
return Logger{
92-
Logger: zapr.NewLogger(logger).WithName(name),
93-
logging: l.logging,
94-
out: l.out,
95-
sugaredLogger: logger.Sugar().Named(name),
96-
}
92+
return Logger{
93+
Logger: zapr.NewLogger(logger).WithName(name),
94+
logging: l.logging,
95+
out: l.out,
96+
sugaredLogger: logger.Sugar().Named(name),
97+
}
9798
}
9899

99100
// WithValues returns a new Logger instance with additional key/value pairs.
100101
// See Info for documentation on how key/value pairs work.
101102
func (l Logger) WithValues(keysAndValues ...interface{}) Logger {
102103

103-
l.Logger = l.Logger.WithValues(keysAndValues...)
104-
return l
104+
l.Logger = l.Logger.WithValues(keysAndValues...)
105+
return l
105106
}
106107

107108
// A Sugar wraps the base Logger functionality in a slower, but less
@@ -124,13 +125,13 @@ func (l Logger) WithValues(keysAndValues ...interface{}) Logger {
124125
// Infoln(...any) Println-style logger
125126
func (l Logger) Sugar() *zap.SugaredLogger {
126127

127-
return l.sugaredLogger
128+
return l.sugaredLogger
128129
}
129130

130131
func initZapLogger(w io.Writer, logging *logger.HertzBeatLogging, level logger.LogLevel) *zap.Logger {
131132

132-
parseLevel, _ := zapcore.ParseLevel(string(logging.DefaultHertzBeatLoggingLevel(level)))
133-
core := zapcore.NewCore(zapcore.NewConsoleEncoder(zap.NewDevelopmentEncoderConfig()), zapcore.AddSync(w), zap.NewAtomicLevelAt(parseLevel))
133+
parseLevel, _ := zapcore.ParseLevel(string(logging.DefaultHertzBeatLoggingLevel(level)))
134+
core := zapcore.NewCore(zapcore.NewConsoleEncoder(zap.NewDevelopmentEncoderConfig()), zapcore.AddSync(w), zap.NewAtomicLevelAt(parseLevel))
134135

135-
return zap.New(core, zap.AddCaller())
136+
return zap.New(core, zap.AddCaller())
136137
}

tools/linter/license/.licenserc.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ header:
5959
- 'tools/linter/yamllint/.yamllint'
6060
- '.go-version'
6161
- 'VERSION'
62+
- '.editorconfig'
6263

6364
comment: on-failure
6465

tools/linter/markdownlint/markdown_lint_config.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,3 +44,5 @@ MD051: false
4444
MD056: false
4545
# MD055/table-pipe-style
4646
MD055: false
47+
# MD060/table
48+
MD060: false

tools/make/linter.mk

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
.PHONY: lint
2121
lint: ## Check files
22-
lint: markdown-lint-check yaml-lint codespell newline-check
22+
lint: markdown-lint-check yaml-lint codespell
2323

2424
.PHONY: codespell
2525
codespell: CODESPELL_SKIP := $(shell cat tools/linter/codespell/.codespell.skip | tr \\n ',')
@@ -64,16 +64,6 @@ markdown-lint-fix: ## Fix the markdown files style.
6464
markdownlint --version
6565
markdownlint --config ./tools/linter/markdownlint/markdown_lint_config.yaml --fix .
6666

67-
.PHONY: newline-check
68-
newline-check: ## Check the newline
69-
@$(LOG_TARGET)
70-
python3 tools/scripts/new-line-check.py check
71-
72-
.PHONY: newline-fix
73-
newline-fix: ## Fix the newline
74-
@$(LOG_TARGET)
75-
python3 tools/scripts/new-line-check.py fix
76-
7767
.PHONY: secrets-check
7868
secrets-check: ## Check the secrets
7969
@$(LOG_TARGET)

tools/scripts/new-line-check.py

Lines changed: 0 additions & 112 deletions
This file was deleted.

0 commit comments

Comments
 (0)