HADOOP-18975 fips: yetus review

Change-Id: I2395d5246ab2d46989bf32973b31722df45a7cad

Author: steveloughran

hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/connecting.md

@@ -129,15 +129,14 @@ See [Timeouts](performance.html#timeouts).
   <value>Default_JSSE</value>
   <description>
     TLS implementation and cipher options.
-    
     Values: OpenSSL, Default, Default_JSSE, Default_JSSE_with_GCM
 
     Default_JSSE is not truly the the default JSSE implementation because
     the GCM cipher is disabled when running on Java 8. However, the name
     was not changed in order to preserve backwards compatibility. Instead,
     new mode called Default_JSSE_with_GCM delegates to the default JSSE
     implementation with no changes to the list of enabled ciphers.
-    
+
     OpenSSL requires the wildfly JAR on the classpath and a compatible installation of the openssl binaries.
     It is often faster than the JVM libraries, but also trickier to
     use.
@@ -428,10 +427,10 @@ Before using Access Points make sure you're not impacted by the following:
 considering endpoints, if you have any custom signers that use the host endpoint property make
 sure to update them if needed;
 
- 
 ## <a name="debugging"></a> Debugging network problems
 
-The `storediag` command within the utility [cloudstore](https://github.com/exampleoughran/cloudstore) JAR is recommended as the way to view and print settings.
+The `storediag` command within the utility [cloudstore](https://github.com/exampleoughran/cloudstore)
+JAR is recommended as the way to view and print settings.
 
 If `storediag` doesn't connect to your S3 store, *nothing else will*.
 

hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AEndpointRegion.java

@@ -178,9 +178,8 @@ public void testWithFips() throws Throwable {
   public void testWithFipsAndEndpoint() throws Throwable {
     describe("Create a client with fips and an endpoint");
 
-    intercept(IllegalArgumentException.class, ERROR_ENDPOINT_WITH_FIPS,
-        () ->createS3Client(getConfiguration(),
-                CENTRAL_ENDPOINT, null, US_EAST_1, true));
+    intercept(IllegalArgumentException.class, ERROR_ENDPOINT_WITH_FIPS, () ->
+        createS3Client(getConfiguration(), CENTRAL_ENDPOINT, null, US_EAST_1, true));
   }
 
   @Test
@@ -291,7 +290,9 @@ public void beforeExecution(Context.BeforeExecution context,
               executionAttributes.getAttribute(AwsExecutionAttribute.AWS_REGION).toString())
           .describedAs("Incorrect region set").isEqualTo(region);
 
-      Assertions.assertThat(executionAttributes.getAttribute(AwsExecutionAttribute.FIPS_ENDPOINT_ENABLED))
+      // verify the fips state matches expectation.
+      Assertions.assertThat(executionAttributes.getAttribute(
+          AwsExecutionAttribute.FIPS_ENDPOINT_ENABLED))
           .describedAs("Incorrect FIPS flag set").isEqualTo(isFips);
 
       // We don't actually want to make a request, so exit early.