Commit 6f86c7f
authored
docs(config_center/zookeeper): align README and comments with actual code (#1094)
The sample's README and an inline comment had three inconsistencies that
confused users following the docs:
- Triple port: README showed `port: 20000`, but the YAML pushed to ZK in
go-server/cmd/main.go uses `port: 50000`. The server actually listens
on 50000, so update README to match.
- DataID: README and the inline comment in main.go used
`dubbo-go-samples-configcenter-zookeeper-server`, but the actual
WithDataID() call and the ZK path use
`dubbo-go-samples-configcenter-zookeeper-go-server` (with `-go-`).
Update both docs to match the code.
- Zookeeper start command: README said `docker compose up -d zookeeper`,
but the repo has no compose file for it, so the command fails.
Replace with a concrete `docker run` and a link to the official
Zookeeper installation guide.
Both README.md and README_zh.md are kept in sync.
Closes #1081
Closes #1082
Closes #10841 parent 800e8bc commit 6f86c7f
3 files changed
Lines changed: 22 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
9 | 12 | | |
10 | 13 | | |
11 | | - | |
| 14 | + | |
12 | 15 | | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
13 | 19 | | |
14 | 20 | | |
15 | 21 | | |
| |||
22 | 28 | | |
23 | 29 | | |
24 | 30 | | |
25 | | - | |
| 31 | + | |
26 | 32 | | |
27 | 33 | | |
28 | 34 | | |
| |||
36 | 42 | | |
37 | 43 | | |
38 | 44 | | |
39 | | - | |
| 45 | + | |
40 | 46 | | |
41 | 47 | | |
42 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
9 | 13 | | |
10 | | - | |
| 14 | + | |
11 | 15 | | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
12 | 19 | | |
13 | 20 | | |
14 | 21 | | |
| |||
21 | 28 | | |
22 | 29 | | |
23 | 30 | | |
24 | | - | |
| 31 | + | |
25 | 32 | | |
26 | 33 | | |
27 | 34 | | |
| |||
35 | 42 | | |
36 | 43 | | |
37 | 44 | | |
38 | | - | |
| 45 | + | |
39 | 46 | | |
40 | 47 | | |
41 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
90 | | - | |
| 90 | + | |
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
| |||
0 commit comments