Skip to content

Commit 25b15ad

Browse files
authored
CI: Remove disabled checks for semver and downstream (#429)
#### Problem The main CI job has two jobs disabled: semver-checks and downstream agave checks. The semver-checks job on every PR is more trouble than it's worth, so we only run it before publishing, when semver breakage truly matters. The downstream Agave check has a similar problem, where it quickly goes red. #### Summary of changes Just remove them. I kept the downstream testing script, since it can still be useful in certain situations, just not in CI. The semver-check script is pretty useless though, so I removed that.
1 parent f544553 commit 25b15ad

File tree

2 files changed

+0
-52
lines changed

2 files changed

+0
-52
lines changed

.github/workflows/main.yml

Lines changed: 0 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -91,26 +91,6 @@ jobs:
9191
- name: Check formatting
9292
run: ./scripts/check-fmt.sh
9393

94-
check-downstream-agave:
95-
if: false # re-enable after agave uses loader-v3-interface v3
96-
name: Cargo check Agave master
97-
runs-on: ubuntu-latest
98-
needs: [sanity]
99-
steps:
100-
- name: Git Checkout
101-
uses: actions/checkout@v4
102-
103-
- name: Setup Environment
104-
uses: ./.github/actions/setup
105-
with:
106-
agave: true
107-
stable-toolchain: true
108-
cargo-cache-key: cargo-downstream-agave-check
109-
cargo-cache-fallback-key: cargo-downstream-agave
110-
111-
- name: Run checks
112-
run: ./scripts/check-downstream-agave.sh
113-
11494
clippy:
11595
name: Clippy
11696
needs: [sanity]
@@ -182,30 +162,6 @@ jobs:
182162
- name: Run cargo-audit
183163
run: ./scripts/check-audit.sh
184164

185-
semver:
186-
if: false # enable after 2.2.0 is cut
187-
name: Check semver
188-
runs-on: ubuntu-latest
189-
needs: [sanity]
190-
steps:
191-
- name: Git Checkout
192-
uses: actions/checkout@v4
193-
194-
- name: Setup Environment
195-
uses: ./.github/actions/setup
196-
with:
197-
stable-toolchain: true
198-
cargo-cache-key: cargo-stable-semver
199-
cargo-cache-fallback-key: cargo-stable
200-
201-
- name: Install cargo-semver-checks
202-
uses: taiki-e/cache-cargo-install-action@v2
203-
with:
204-
tool: cargo-semver-checks
205-
206-
- name: Run semver checks
207-
run: ./scripts/check-semver.sh
208-
209165
check:
210166
name: Cargo hack check
211167
runs-on: ubuntu-latest

scripts/check-semver.sh

Lines changed: 0 additions & 8 deletions
This file was deleted.

0 commit comments

Comments
 (0)