Skip to content

Commit 53b76ba

Browse files
committed
Skip Windows unit tests for unsupported features
Skipping unit tests for all features explicitly listed as unsupported on Windows (e.g., NodeLatencyMonitor, Egress). This change was initiated following the observation of flaky failures in monitor tool Windows unit tests. Disabling all related tests improves CI stability and releases resources. Signed-off-by: Shuyang Xin <[email protected]>
1 parent e2eb6aa commit 53b76ba

File tree

11 files changed

+62
-2
lines changed

11 files changed

+62
-2
lines changed

Makefile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,9 +291,10 @@ add-copyright:
291291
.windows-test-unit: .coverage
292292
@echo
293293
@echo "==> Running unit tests <=="
294-
CGO_ENABLED=1 $(GO) test $(TEST_ARGS) -race -coverpkg=antrea.io/antrea/cmd/...,antrea.io/antrea/pkg/... \
294+
@pkgs=$$($(GO) list antrea.io/antrea/cmd/... antrea.io/antrea/pkg/... | grep -v antrea.io/antrea/pkg/agent/controller | grep -v antrea.io/antrea/pkg/controller); \
295+
CGO_ENABLED=1 $(GO) test $(TEST_ARGS) -race -coverpkg=$$(echo "$$pkgs" | tr '\n' ',' | sed 's/,$$//') \
295296
-coverprofile=.coverage/coverage-unit.txt -covermode=atomic \
296-
antrea.io/antrea/cmd/... antrea.io/antrea/pkg/...
297+
$$pkgs
297298

298299
.PHONY: tidy
299300
tidy:

pkg/agent/monitortool/latency_store.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
//go:build !windows
2+
13
// Copyright 2024 Antrea Authors
24
//
35
// Licensed under the Apache License, Version 2.0 (the "License");

pkg/agent/monitortool/latency_store_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
//go:build !windows
2+
13
// Copyright 2024 Antrea Authors
24
//
35
// Licensed under the Apache License, Version 2.0 (the "License");

pkg/agent/monitortool/monitor.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
//go:build !windows
2+
13
// Copyright 2024 Antrea Authors
24
//
35
// Licensed under the Apache License, Version 2.0 (the "License");

pkg/agent/monitortool/monitor_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
//go:build !windows
2+
13
// Copyright 2024 Antrea Authors
24
//
35
// Licensed under the Apache License, Version 2.0 (the "License");
Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
//go:build windows
2+
3+
// Copyright 2025 Antrea Authors
4+
//
5+
// Licensed under the Apache License, Version 2.0 (the "License");
6+
// you may not use this file except in compliance with the License.
7+
// You may obtain a copy of the License at
8+
//
9+
// http://www.apache.org/licenses/LICENSE-2.0
10+
//
11+
// Unless required by applicable law or agreed to in writing, software
12+
// distributed under the License is distributed on an "AS IS" BASIS,
13+
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
// See the License for the specific language governing permissions and
15+
// limitations under the License.
16+
17+
package monitortool
18+
19+
import (
20+
coreinformers "k8s.io/client-go/informers/core/v1"
21+
22+
"antrea.io/antrea/pkg/agent/client"
23+
"antrea.io/antrea/pkg/agent/config"
24+
crdinformers "antrea.io/antrea/pkg/client/informers/externalversions/crd/v1alpha1"
25+
)
26+
27+
type NodeLatencyMonitor struct{}
28+
29+
func NewNodeLatencyMonitor(
30+
antreaClientProvider client.AntreaClientProvider,
31+
nodeInformer coreinformers.NodeInformer,
32+
nlmInformer crdinformers.NodeLatencyMonitorInformer,
33+
nodeConfig *config.NodeConfig,
34+
trafficEncapMode config.TrafficEncapModeType,
35+
) *NodeLatencyMonitor {
36+
return &NodeLatencyMonitor{}
37+
}
38+
39+
func (m *NodeLatencyMonitor) Run(stopCh <-chan struct{}) {}
40+
41+
// Not supported on Windows.

pkg/agent/multicast/mcast_controller_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
//go:build !windows
2+
13
// Copyright 2021 Antrea Authors
24
//
35
// Licensed under the Apache License, Version 2.0 (the "License");

pkg/agent/multicast/mcast_discovery_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
//go:build !windows
2+
13
// Copyright 2022 Antrea Authors
24
//
35
// Licensed under the Apache License, Version 2.0 (the "License");

pkg/agent/multicluster/mc_route_controller_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
//go:build !windows
2+
13
// Copyright 2022 Antrea Authors
24
//
35
// Licensed under the Apache License, Version 2.0 (the "License");

pkg/agent/multicluster/pod_route_controller_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
//go:build !windows
2+
13
// Copyright 2023 Antrea Authors
24
//
35
// Licensed under the Apache License, Version 2.0 (the "License");

0 commit comments

Comments
 (0)