fix(drawer): drawer container animating when open by default #7129
Conversation
googlebot
added
the
cla: yes
| .subscribe((event: AnimationEvent) => { | ||
| // Set the transition class on the container so that the animations occur. This should not | ||
| // be set initially because animations should only be triggered via a change in state. | ||
| if (event.toState !== 'open-instant') { |
There was a problem hiding this comment.
this._element.nativeElement.classList.toggle('mat-drawer-transition', event.toState != 'open-instant');There was a problem hiding this comment.
The second param isn’t supported on IE.
There was a problem hiding this comment.
Ah, in that case can we still at least use classList.add instead of the Renderer
There was a problem hiding this comment.
The renderer is SSR-friendly. AFAIK we can stop using it in Angular 5.
There was a problem hiding this comment.
Don't animation events not fire on the server?
There was a problem hiding this comment.
AFAIK they could fire if the sidenav starts off opened.
There was a problem hiding this comment.
Hmm ok, just needs rebase then
crisbeto
force-pushed
the
7007/drawer-container-initial-animation
branch
2 times, most recently
from
fc16ed9 to
537882b
Compare
crisbeto
added
action: merge
|
@crisbeto Fix linter failure? |
* Prevents the drawer container from animating if it's open on load. * Fixes `_updateStyles` being called twice in a row on init, because the first animations are `void->void` and `void->open-instant`. Fixes angular#7007.
crisbeto
force-pushed
the
7007/drawer-container-initial-animation
branch
from
537882b to
9b8968c
Compare
|
Ready to go. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
_updateStylesbeing called twice in a row on init, because the first animations arevoid->voidandvoid->open-instant.Fixes #7007.