fix(progress-spinner): set spinner width to match diameter #10314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephperrott
added
pr: needs review
target: patch
googlebot
added
the
cla: yes
jelbourn
reviewed
Mar 7, 2018
jelbourn
added
pr: lgtm
action: merge
|
@josephperrott looks like there are some test failures and a few lint warnings. |
josephperrott
force-pushed
the
progress-spinner
branch
2 times, most recently
from
bf9ae40 to
35cc471
Compare
josephperrott
force-pushed
the
progress-spinner
branch
from
35cc471 to
f17e8cb
Compare
josephperrott
added
target: minor
josephperrott
force-pushed
the
progress-spinner
branch
3 times, most recently
from
f4b5f2c to
99079be
Compare
josephperrott
force-pushed
the
progress-spinner
branch
from
99079be to
f0e59a7
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10200
Rather than increasing the width of the spinner to accommodate the inclusion of the stroke's width, the strokes width is now accounted for in the width. Said another way, the diameter of the outside of the spinner's circle is used, rather than the diameter of the inner circle.