fix(checkbox): wrong cursor when disabled (#908)

crisbeto · hansl · commit 5251c2784665 · 2016-07-25T13:17:22.000-07:00
Fixes the checkbox using a pointer cursor, even when the element is disabled. Fixes #907.
diff --git a/src/components/checkbox/checkbox.scss b/src/components/checkbox/checkbox.scss
@@ -218,12 +218,13 @@ $_md-checkbox-indeterminate-checked-easing-function: cubic-bezier(0.14, 0, 0, 1)
 }
 
 md-checkbox {
-  &, label {
-    cursor: pointer;
-  }
+  cursor: pointer;
 }
 
 .md-checkbox-layout {
+  // `cursor: inherit` ensures that the wrapper element gets the same cursor as the md-checkbox
+  // (e.g. pointer by default, regular when disabled), instead of the browser default.
+  cursor: inherit;
   align-items: baseline;
   display: inline-flex;
 }

Original file line number	Diff line number	Diff line change
`@@ -218,12 +218,13 @@ $_md-checkbox-indeterminate-checked-easing-function: cubic-bezier(0.14, 0, 0, 1)`
`218`	`218`	`}`
`219`	`219`
`220`	`220`	`md-checkbox {`
`221`		`- &, label {`
`222`		`- cursor: pointer;`
`223`		`- }`
	`221`	`+ cursor: pointer;`
`224`	`222`	`}`
`225`	`223`
`226`	`224`	`.md-checkbox-layout {`
	`225`	+ // `cursor: inherit` ensures that the wrapper element gets the same cursor as the md-checkbox
	`226`	`+ // (e.g. pointer by default, regular when disabled), instead of the browser default.`
	`227`	`+ cursor: inherit;`
`227`	`228`	`align-items: baseline;`
`228`	`229`	`display: inline-flex;`
`229`	`230`	`}`