Skip to content

Commit 0f6a2ec

Browse files
jelbournkara
authored andcommitted
feat(cdk): move cdkScrollable, ScrollDispatcher, and ViewportRuler out of overlay (#6547)
1 parent c90ca55 commit 0f6a2ec

37 files changed

+95
-65
lines changed

src/cdk/overlay/position/connected-position-strategy.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import {ElementRef} from '@angular/core';
22
import {TestBed, inject} from '@angular/core/testing';
33
import {ConnectedPositionStrategy} from './connected-position-strategy';
4-
import {ViewportRuler, VIEWPORT_RULER_PROVIDER} from './viewport-ruler';
4+
import {ViewportRuler, VIEWPORT_RULER_PROVIDER} from '@angular/cdk/scrolling';
55
import {OverlayPositionBuilder} from './overlay-position-builder';
66
import {ConnectedOverlayPositionChange} from './connected-position';
7-
import {Scrollable} from '../scroll/scrollable';
7+
import {Scrollable} from '@angular/cdk/scrolling';
88
import {Subscription} from 'rxjs/Subscription';
9-
import {ScrollDispatchModule} from '../scroll/index';
9+
import {ScrollDispatchModule} from '@angular/cdk/scrolling';
1010
import {OverlayRef} from '../overlay-ref';
1111

1212

src/cdk/overlay/position/connected-position-strategy.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
import {PositionStrategy} from './position-strategy';
1010
import {ElementRef} from '@angular/core';
11-
import {ViewportRuler} from './viewport-ruler';
11+
import {ViewportRuler} from '@angular/cdk/scrolling';
1212
import {
1313
ConnectionPositionPair,
1414
OriginConnectionPosition,
@@ -18,7 +18,7 @@ import {
1818
} from './connected-position';
1919
import {Subject} from 'rxjs/Subject';
2020
import {Observable} from 'rxjs/Observable';
21-
import {Scrollable} from '../scroll/scrollable';
21+
import {Scrollable} from '@angular/cdk/scrolling';
2222
import {isElementScrolledOutsideView, isElementClippedByScrolling} from './scroll-clip';
2323
import {OverlayRef} from '../overlay-ref';
2424

src/cdk/overlay/position/overlay-position-builder.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*/
88

99
import {ElementRef, Injectable} from '@angular/core';
10-
import {ViewportRuler} from './viewport-ruler';
10+
import {ViewportRuler} from '@angular/cdk/scrolling';
1111
import {ConnectedPositionStrategy} from './connected-position-strategy';
1212
import {GlobalPositionStrategy} from './global-position-strategy';
1313
import {OverlayConnectionPosition, OriginConnectionPosition} from './connected-position';

src/cdk/overlay/public_api.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,15 @@
88
import {NgModule, Provider} from '@angular/core';
99
import {PortalModule} from '@angular/cdk/portal';
1010
import {Overlay} from './overlay';
11-
import {ScrollDispatchModule} from './scroll/index';
11+
import {ScrollDispatchModule, VIEWPORT_RULER_PROVIDER} from '@angular/cdk/scrolling';
1212
import {
1313
ConnectedOverlayDirective,
14-
OverlayOrigin,
1514
MD_CONNECTED_OVERLAY_SCROLL_STRATEGY_PROVIDER,
15+
OverlayOrigin,
1616
} from './overlay-directives';
1717
import {OverlayPositionBuilder} from './position/overlay-position-builder';
18-
import {VIEWPORT_RULER_PROVIDER} from './position/viewport-ruler';
1918
import {OVERLAY_CONTAINER_PROVIDER} from './overlay-container';
19+
import {ScrollStrategyOptions} from './scroll/scroll-strategy-options';
2020

2121

2222
export const OVERLAY_PROVIDERS: Provider[] = [
@@ -31,7 +31,7 @@ export const OVERLAY_PROVIDERS: Provider[] = [
3131
imports: [PortalModule, ScrollDispatchModule],
3232
exports: [ConnectedOverlayDirective, OverlayOrigin, ScrollDispatchModule],
3333
declarations: [ConnectedOverlayDirective, OverlayOrigin],
34-
providers: [OVERLAY_PROVIDERS],
34+
providers: [OVERLAY_PROVIDERS, ScrollStrategyOptions],
3535
})
3636
export class OverlayModule {}
3737

@@ -42,7 +42,7 @@ export {FullscreenOverlayContainer} from './fullscreen-overlay-container';
4242
export {OverlayRef} from './overlay-ref';
4343
export {OverlayState} from './overlay-state';
4444
export {ConnectedOverlayDirective, OverlayOrigin} from './overlay-directives';
45-
export {ViewportRuler} from './position/viewport-ruler';
45+
export {ViewportRuler} from '@angular/cdk/scrolling';
4646
export {ComponentType} from '@angular/cdk/portal';
4747

4848
export * from './position/connected-position';
@@ -52,4 +52,4 @@ export * from './scroll/index';
5252
export {PositionStrategy} from './position/position-strategy';
5353
export {GlobalPositionStrategy} from './position/global-position-strategy';
5454
export {ConnectedPositionStrategy} from './position/connected-position-strategy';
55-
export {VIEWPORT_RULER_PROVIDER} from './position/viewport-ruler';
55+
export {VIEWPORT_RULER_PROVIDER} from '@angular/cdk/scrolling';

src/cdk/overlay/scroll/block-scroll-strategy.spec.ts

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,9 @@
1-
import {NgModule, Component} from '@angular/core';
2-
import {inject, TestBed, async} from '@angular/core/testing';
1+
import {Component, NgModule} from '@angular/core';
2+
import {async, inject, TestBed} from '@angular/core/testing';
33
import {ComponentPortal, PortalModule} from '@angular/cdk/portal';
44
import {Platform} from '@angular/cdk/platform';
5-
import {
6-
OverlayModule,
7-
ViewportRuler,
8-
OverlayState,
9-
Overlay,
10-
OverlayRef,
11-
OverlayContainer,
12-
} from '../index';
5+
import {ViewportRuler} from '@angular/cdk/scrolling';
6+
import {Overlay, OverlayContainer, OverlayModule, OverlayRef, OverlayState} from '../index';
137

148

159
describe('BlockScrollStrategy', () => {

src/cdk/overlay/scroll/block-scroll-strategy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*/
88

99
import {ScrollStrategy} from './scroll-strategy';
10-
import {ViewportRuler} from '../position/viewport-ruler';
10+
import {ViewportRuler} from '@angular/cdk/scrolling';
1111

1212
/**
1313
* Strategy that will prevent the user from scrolling while the overlay is visible.

src/cdk/overlay/scroll/close-scroll-strategy.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@ import {inject, TestBed, async} from '@angular/core/testing';
22
import {NgModule, Component} from '@angular/core';
33
import {Subject} from 'rxjs/Subject';
44
import {ComponentPortal, PortalModule} from '@angular/cdk/portal';
5+
import {ScrollDispatcher} from '@angular/cdk/scrolling';
56
import {
67
Overlay,
78
OverlayState,
89
OverlayRef,
910
OverlayModule,
10-
ScrollDispatcher,
1111
OverlayContainer,
1212
} from '../index';
1313

src/cdk/overlay/scroll/close-scroll-strategy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import {ScrollStrategy, getMdScrollStrategyAlreadyAttachedError} from './scroll-strategy';
1010
import {OverlayRef} from '../overlay-ref';
1111
import {Subscription} from 'rxjs/Subscription';
12-
import {ScrollDispatcher} from './scroll-dispatcher';
12+
import {ScrollDispatcher} from '@angular/cdk/scrolling';
1313

1414

1515
/**

src/cdk/overlay/scroll/index.ts

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,7 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88

9-
import {NgModule} from '@angular/core';
10-
import {PlatformModule} from '@angular/cdk/platform';
11-
import {SCROLL_DISPATCHER_PROVIDER} from './scroll-dispatcher';
12-
import {Scrollable} from './scrollable';
13-
import {ScrollStrategyOptions} from './scroll-strategy-options';
14-
15-
export {Scrollable} from './scrollable';
16-
export {ScrollDispatcher} from './scroll-dispatcher';
9+
export {Scrollable, ScrollDispatcher} from '@angular/cdk/scrolling';
1710

1811
// Export pre-defined scroll strategies and interface to build custom ones.
1912
export {ScrollStrategy} from './scroll-strategy';
@@ -22,11 +15,3 @@ export {RepositionScrollStrategy} from './reposition-scroll-strategy';
2215
export {CloseScrollStrategy} from './close-scroll-strategy';
2316
export {NoopScrollStrategy} from './noop-scroll-strategy';
2417
export {BlockScrollStrategy} from './block-scroll-strategy';
25-
26-
@NgModule({
27-
imports: [PlatformModule],
28-
exports: [Scrollable],
29-
declarations: [Scrollable],
30-
providers: [SCROLL_DISPATCHER_PROVIDER, ScrollStrategyOptions],
31-
})
32-
export class ScrollDispatchModule { }

src/cdk/overlay/scroll/reposition-scroll-strategy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import {Subscription} from 'rxjs/Subscription';
1010
import {ScrollStrategy, getMdScrollStrategyAlreadyAttachedError} from './scroll-strategy';
1111
import {OverlayRef} from '../overlay-ref';
12-
import {ScrollDispatcher} from './scroll-dispatcher';
12+
import {ScrollDispatcher} from '@angular/cdk/scrolling';
1313

1414
/**
1515
* Config options for the RepositionScrollStrategy.

0 commit comments

Comments
 (0)