This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(list): fix checkbox alignment and match dense heights to spec #11971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Splaktar
added
- Breaking Change
CSS: High Density
ui: CSS
P1: urgent
Splaktar
force-pushed
the
list-fix-checkbox-alignment
branch
from
1a5ef09 to
12605fe
Compare
Splaktar
added
the
type: spec alignment
wagnermaciel
approved these changes
Jul 22, 2020
- match the spec update where `md-dense` list items are `40px` in height by default - was `48px` in height - support `.md-dense-disabled` - for `.md-dense` lists: align heights with spec for list items with primary icons, avatars/avatar icons, secondary buttons, and checkboxes - `md-subheaders` in `.md-dense` lists should match the single line list item height - `48px` -> `40px` Fixes #11966 BREAKING CHANGE: `md-list` with the `md-dense` class has been updated to align with the Material Design specification. This means that `md-list-item`s heights have changed when using `md-dense`. The `md-dense-disabled` class is now supported on `md-list`. After updating to this version, you may need to adjust the layout of your app if you use `md-dense` with `md-list` or customize the layout of `md-checkbox`s within `md-list-item`s.
Splaktar
force-pushed
the
list-fix-checkbox-alignment
branch
from
12605fe to
698b3ba
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
.md-dense-disabledis not supported with lists.md-denselist item heights don't match the specIssue Number:
Fixes #11966
What is the new behavior?
md-denselist items are40pxin height by default48pxin height.md-dense-disabled.md-denselists: align heights with spec for list items with primary icons,avatars/avatar icons, secondary buttons, and checkboxes
md-subheadersin.md-denselists should match the single line list item height48px->40pxDoes this PR introduce a breaking change?
BREAKING CHANGE:
md-listwith themd-denseclass has been updated to align with the Material Design specification. This means thatmd-list-items heights have changed when usingmd-dense. Themd-dense-disabledclass is now supported onmd-list. After updating to this version, you may need to adjust the layout of your app if you usemd-densewithmd-listor customize the layout ofmd-checkboxs withinmd-list-items.Other information
Dense
Default