Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Commit 84519a7

Browse files
committed
refactor(tabs): remove deprecated md-no-disconnect
1 parent fe081c5 commit 84519a7

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

src/components/tabs/js/tabsController.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,6 @@ function MdTabsController ($scope, $element, $window, $mdConstant, $mdTabInkRipp
6363
defineBooleanAttribute('dynamicHeight', handleDynamicHeight);
6464
defineBooleanAttribute('noPagination');
6565
defineBooleanAttribute('swipeContent');
66-
// TODO remove noDisconnect in 1.2.0
67-
defineBooleanAttribute('noDisconnect');
6866
defineBooleanAttribute('autoselect');
6967
defineBooleanAttribute('noSelectClick');
7068
defineBooleanAttribute('centerTabs', handleCenterTabs);
@@ -449,8 +447,7 @@ function MdTabsController ($scope, $element, $window, $mdConstant, $mdTabInkRipp
449447
isActive: function () { return this.getIndex() === ctrl.selectedIndex; },
450448
isLeft: function () { return this.getIndex() < ctrl.selectedIndex; },
451449
isRight: function () { return this.getIndex() > ctrl.selectedIndex; },
452-
// TODO remove reference to noDisconnect in 1.2.0
453-
shouldRender: function () { return !ctrl.noDisconnect || this.isActive(); },
450+
shouldRender: function () { return ctrl.dynamicHeight || this.isActive(); },
454451
hasFocus: function () {
455452
return ctrl.styleTabItemFocus
456453
&& ctrl.hasFocus && this.getIndex() === ctrl.focusIndex;

src/components/tabs/js/tabsDirective.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,6 @@
8484
* @param {boolean=} md-enable-disconnect When enabled, scopes will be disconnected for tabs that
8585
* are not being displayed. This provides a performance boost, but may also cause unexpected
8686
* issues. It is not recommended for most users.
87-
* @param {boolean=} md-no-disconnect **Deprecated**: If your tab content has background tasks
88-
* (ie. event listeners), you will want to include this to prevent the scope from being
89-
* disconnected.
9087
* @param {boolean=} md-autoselect If the attribute is present, any tabs added after the initial
9188
* load will be automatically selected.
9289
* @param {boolean=} md-no-select-click When true, click events will not be fired when the value of

0 commit comments

Comments
 (0)