fix(gestures): custom recognizers should not inherit twice. #902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
cla: yes
|
@devversion A few notes:
|
* HammerJS does not allow custom recognizers to use a default recognizer twice globally. This means that we can't create a `drag` and `slide` recognizer, which depends for all on one default recognizers.
devversion
force-pushed
the
fix/gestures-twice-inheritances
branch
from
b4c073f to
da5f6f5
Compare
|
@kara Done! |
|
Thanks for updating! LGTM |
kara
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that we can't create a
dragandsliderecognizer, which depends for all on one default recognizers.As discussed with @kara this is another approach for fixing that gesture issues.