Skip to content

fix(input): don't highlight container when readonly input is focused #7273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

crisbeto
Copy link
Member

Prevents readonly inputs from being highlighted when they're focused. This is consistent with the native input behavior.

Note: This was introduced initially through #5776, but it looks like it didn't make it through the transition to mat-form-field.

@crisbeto crisbeto requested a review from mmalerba as a code owner September 23, 2017 15:18
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 23, 2017
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Sep 23, 2017
Prevents readonly inputs from being highlighted when they're focused. This is consistent with the native input behavior.

Note: This was introduced initially through angular#5776, but it looks like it didn't make it through the transition to `mat-form-field`.
@crisbeto crisbeto force-pushed the readonly-input-highlight-again branch from 4fc0619 to e570709 Compare September 29, 2017 16:35
@andrewseguin andrewseguin merged commit f076390 into angular:master Sep 29, 2017
@andrewseguin
Copy link
Contributor

From internal testing - looks like this a regression of the native input's readonly attribute.

e.g. <input [readonly]=true> will result in <input ng-reflect-readonly=true> instead of <input readonly>

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants