chore(data-table): hide stability warning in jasmine

[devversion]

• No longer shows the data-table stability warning inside of jasmine tests.

[andrewseguin]

Looping in Jeremy, he requested the data table warning to be a bit more intrusive to make it clear that it's not yet ready

[jelbourn]

This isn't part of the sanity checks

[devversion]

Yeah it isn't really a sanity check but it allows us to disable those warnings in tests.

Having the warning super-intrusive just spams the whole tests and doesn't really help at all.

I initially only wanted to show the warning in dev-mode only but after chatting with @crisbeto I agreed that it would be nice if developers can disable the warning though

[jelbourn]

I'd rather add a check for window.jasmine to disable it so that we just don't log it during our own tests

[devversion]

That would work too. But the issue doesn't just appear in Material. Every developer that writes tests using Material will get all of those data-table errors.

The sanity checks solution would be kind of temporary until this warning will be removed anyways. But for now it's a super intrusive warning.

[jelbourn]

@devversion the warning is in the constructor of the table- they'll only get it if they use the table, which is exactly the point

[devversion]

@jelbourn Yeah that's clear. But as I mentioned everybody that tests for example a component that contains a md-data-table will get the error. Similar as we do by explicitly testing the md-data-table.

[devversion]

@jelbourn I'm fine doing the window.jasmine thing since you said that nobody should use the data-table at all yet (and it's exposed for the demo-app). Let me know if I should proceed with that.

[devversion]

@andrewseguin @jelbourn Made the requested changes. Please review again.

[jelbourn]

LGTM

[andrewseguin]

Can you rebase?

[devversion]

@andrewseguin Done

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}