feat(data-table): use iterate differ to optimize rendering #4823
Conversation
googlebot
added
the
cla: yes
|
|
||
| // Swap first and second data in data array | ||
| let copiedData = component.dataSource.data.slice(); | ||
| let temp = copiedData[0]; |
| @@ -92,9 +98,13 @@ export class CdkTable implements CollectionViewer { | |||
| /** Set of templates that used as the data row containers. */ | |||
| @ContentChildren(CdkRowDef) _rowDefinitions: QueryList<CdkRowDef>; | |||
|
|
|||
| constructor(private _changeDetectorRef: ChangeDetectorRef) { | |||
| constructor(private _differs: IterableDiffers, | |||
| private _changeDetectorRef: ChangeDetectorRef) { | |||
There was a problem hiding this comment.
Should both of these be readonly as well?
There was a problem hiding this comment.
I don't think we've set that precedent, but I can talk with Jeremy about adding it to here and other components as well
There was a problem hiding this comment.
Yeah, they should be readonly; we started the library before readonly was a thing and never got in the habit of adding it later
| @@ -76,6 +79,9 @@ export class CdkTable implements CollectionViewer { | |||
| */ | |||
| private _columnDefinitionsByName = new Map<string, CdkColumnDef>(); | |||
|
|
|||
| /** Differ used to find the changes in the data provided by the data source. */ | |||
| private _dataDiffer: IterableDiffer<any> = null; | |||
There was a problem hiding this comment.
One thing we should consider doing before this is released is making it CdkTable<T> and using the generic throughout
There was a problem hiding this comment.
Added a generic to the CdkTable definition
| console.warn('The data table is still in active development ' + | ||
| 'and should be considered unstable.'); | ||
|
|
||
| // TODO(andrewseguin): Add trackby function input. | ||
| this._dataDiffer = this._differs.find([]).create(); |
There was a problem hiding this comment.
I don't quite follow how this works; why is this find necessary? Can you not just create an IterableDiffer directly? Why is the DI system involved?
(probably just needs explanation in comments)
There was a problem hiding this comment.
Added some comment mentioning that we need to find an iterable differ used for array-based iterables. It's the only public API that lets us grab it, no luck instantiating one myself.
andrewseguin
force-pushed
the
table-differs
branch
from
097cf5e to
017a404
Compare
jelbourn
added
pr: lgtm
action: merge
|
Just noticed still needs |
|
Thanks for catching that, got the readonly in, thought I had changed that already. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.