Skip to content

fix(material/form-field): handle datepicker inputs in harness #22403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2021
Merged

fix(material/form-field): handle datepicker inputs in harness #22403

merged 1 commit into from
May 3, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 5, 2021

Resolves a TODO about supporting datepicker inputs in the form field harness.

Also fixes an error that is thrown when the date range input is combined with an MDC-based form field.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Apr 5, 2021
@crisbeto crisbeto requested review from devversion and mmalerba April 5, 2021 16:04
@crisbeto crisbeto requested a review from a team as a code owner April 5, 2021 16:04
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 5, 2021
@josephperrott josephperrott removed the request for review from a team April 5, 2021 16:14
@crisbeto crisbeto force-pushed the form-field-harness-datepicker branch from ed75279 to 72ba268 Compare April 5, 2021 16:24
@crisbeto crisbeto requested a review from andrewseguin as a code owner April 5, 2021 16:24
@mmalerba mmalerba added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Apr 6, 2021
@mmalerba
Copy link
Contributor

mmalerba commented Apr 6, 2021

I updated the label on this to major because I think the change in type for FormFieldControlHarness could mean people have to update their tests to cast to a stricter type

mmalerba
mmalerba approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 7, 2021
@crisbeto crisbeto added this to the 12.0.0 milestone Apr 7, 2021
@crisbeto crisbeto added target: rc This PR is targeted for the next release-candidate and removed target: major This PR is targeted for the next major release labels Apr 14, 2021
@crisbeto
fix(material/form-field): handle datepicker inputs in harness
a56e99a 
Resolves a TODO about supporting datepicker inputs in the form field harness.

Also fixes an error that is thrown when the date range input is combined with an MDC-based form field.
@crisbeto crisbeto force-pushed the form-field-harness-datepicker branch from 72ba268 to a56e99a Compare April 28, 2021 18:23
@annieyw annieyw merged commit f9cc564 into angular:master May 3, 2021
annieyw pushed a commit that referenced this pull request May 3, 2021
@crisbeto @annieyw
fix(material/form-field): handle datepicker inputs in harness (#22403)
ec266be 
Resolves a TODO about supporting datepicker inputs in the form field harness.

Also fixes an error that is thrown when the date range input is combined with an MDC-based form field.

(cherry picked from commit f9cc564)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@devversion devversion Awaiting requested review from devversion

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
12.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @mmalerba @annieyw