-
Notifications
You must be signed in to change notification settings - Fork 6.8k
chore: create build artifacts for each commit #2082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c5037a6
to
6c8ba58
Compare
6c8ba58
to
9537d1b
Compare
1eb2205
to
fbb45d7
Compare
716e1bc
to
22d7dba
Compare
@jelbourn Should be good for review. Now using the personal repository as discussed for testing. |
@@ -0,0 +1,11 @@ | |||
#!/bin/bash | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a top-level comment explaining the purpose of this file
@@ -0,0 +1,43 @@ | |||
#!/bin/bash | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a top-level comment explaining the purpose of this file
cd $(dirname $0)/../.. | ||
|
||
BUILD_DIR="dist/@angular/material" | ||
BUILD_VERSION=`sed -nE 's/^\s*"version": "(.*?)",$/\1/p' package.json` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer using $( ... )
over ticks for bash:
# Extract the current version from package.json
BUILD_VERSION=$(sed -nE 's/^\s*"version": "(.*?)",$/\1/p' package.json)
(here and elsewhere)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ToDo's
travis_after_all
and for pushing the buildsmaterial-builds
Wrote a plugin to wait for all Travis modes to finish (travis-after-modes)