Skip to content

chore: add style compatibility modes and mat- prefix #1932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 2, 2016

Conversation

jelbourn
Copy link
Member

R: @kara
CC: @IgorMinar

This PR does two things:

  1. Every directive with an md- prefixed selector now also has an additonal mat- prefixed selector.
  2. Adds modules for "compatibility mode". There are two modes:
    • Default mode: forbids the use of mat- prefixes
    • No-conflict mode: allows mat-, forbids the use of md- prefixes

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 19, 2016
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Nov 29, 2016
import {MdIconRegistry} from './icon-registry';
export {MdIconRegistry} from './icon-registry';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this export {MdIconRegistry}?

@tinayuangao tinayuangao merged commit 4d678d4 into angular:master Dec 2, 2016
@jelbourn jelbourn deleted the css-no-conflict branch September 13, 2017 04:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants