Skip to content

fix: add exportAs to missing components/directives #10864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: add exportAs to missing components/directives #10864

wants to merge 1 commit into from

Conversation

rafaelss95
Copy link
Contributor

@rafaelss95 rafaelss95 commented Apr 15, 2018

To make sure that we don't forget about it, I've added it to the validate-decorators rule.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 15, 2018
@rafaelss95
Copy link
Contributor Author

rafaelss95 commented Apr 15, 2018

As the regex I used in validate-decorators#exportAs rule is a little bit strict, I had to disable this rule in 3 places (Dir, Table#RowPlaceholder and Table#HeaderRowPlaceholder). What do you guys think about it?

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that adding this to absolutely everything make sense. The reason a lot of these components weren't exposed was because it just doesn't provide any value (e.g. for directives like MatCardContent and MatCardTitle).

@rafaelss95
Copy link
Contributor Author

Got it. In this case, should I close this?

@jelbourn
Copy link
Member

@rafaelss95 yeah; like @crisbeto said, it's not something that goes on every directive, instead only being applied when there would be some API you'd need to access for a feature

@jelbourn jelbourn closed this Apr 17, 2018
@rafaelss95 rafaelss95 deleted the fix-export-as branch April 18, 2018 00:01
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants