Address feedback

Author: devversion

src/demo-app/style/style-demo.html

@@ -1,10 +1,10 @@
 <button #b class="demo-focusable" cdkMonitorElementFocus>focus me!</button>
 <button (click)="b.focus()">focus programmatically</button>
 
-<button (click)="fom.focusVia(b, 'mouse')">focusVia: mouse</button>
-<button (click)="fom.focusVia(b, 'touch')">focusVia: touch</button>
-<button (click)="fom.focusVia(b, 'keyboard')">focusVia: keyboard</button>
-<button (click)="fom.focusVia(b, 'program')">focusVia: program</button>
+<button (click)="fom.focusVia(b, renderer, 'mouse')">focusVia: mouse</button>
+<button (click)="fom.focusVia(b, renderer, 'touch')">focusVia: touch</button>
+<button (click)="fom.focusVia(b, renderer, 'keyboard')">focusVia: keyboard</button>
+<button (click)="fom.focusVia(b, renderer, 'program')">focusVia: program</button>
 
 <div>Active classes: {{b.classList}}</div>
 

src/demo-app/style/style-demo.ts

@@ -9,5 +9,5 @@ import {FocusOriginMonitor} from '@angular/material';
   styleUrls: ['style-demo.css'],
 })
 export class StyleDemo {
-  constructor(public fom: FocusOriginMonitor) {}
+  constructor(public renderer: Renderer2, public fom: FocusOriginMonitor) {}
 }

src/lib/checkbox/checkbox.spec.ts

@@ -814,8 +814,8 @@ class SingleCheckbox {
   checkboxColor: string = 'primary';
   checkboxValue: string = 'single_checkbox';
 
-  onCheckboxClick(_event: Event) {}
-  onCheckboxChange(_event: MdCheckboxChange) {}
+  onCheckboxClick: (event?: Event) => void = () => {};
+  onCheckboxChange: (event?: MdCheckboxChange) => void = () => {};
 }
 
 /** Simple component for testing an MdCheckbox with ngModel. */

src/lib/checkbox/checkbox.ts

@@ -372,7 +372,7 @@ export class MdCheckbox extends _MdCheckboxMixinBase
 
   /** Focuses the checkbox. */
   focus(): void {
-    this._focusOriginMonitor.focusVia(this._inputElement.nativeElement, 'keyboard');
+    this._focusOriginMonitor.focusVia(this._inputElement.nativeElement, this._renderer, 'keyboard');
   }
 
   _onInteractionEvent(event: Event) {

src/lib/chips/chip-list.spec.ts

@@ -238,6 +238,6 @@ class StaticChipList {
   selectable: boolean = true;
   remove: number;
 
-  chipSelect(_index: number) {}
-  chipDeselect(_index: number) {}
+  chipSelect: (index?: number) => void = () => {};
+  chipDeselect: (index?: number) => void = () => {};
 }

src/lib/chips/chip.spec.ts

@@ -135,10 +135,10 @@ class SingleChip {
   selected: boolean = false;
   shouldShow: boolean = true;
 
-  chipFocus(_event: MdChipEvent) {}
-  chipDestroy(_event: MdChipEvent) {}
-  chipSelect(_event: MdChipEvent) {}
-  chipDeselect(_event: MdChipEvent) {}
+  chipFocus: (event?: MdChipEvent) => void = () => {};
+  chipDestroy: (event?: MdChipEvent) => void = () => {};
+  chipSelect: (event?: MdChipEvent) => void = () => {};
+  chipDeselect: (event?: MdChipEvent) => void = () => {};
 }
 
 @Component({

src/lib/core/datetime/native-date-adapter.ts

@@ -31,7 +31,11 @@ const DEFAULT_DAY_OF_WEEK_NAMES = {
 
 /** Creates an array and fills it with values. */
 function range<T>(length: number, valueFunction: (index: number) => T): T[] {
-  return Array.apply(null, Array(length)).map((_v: undefined, i: number) => valueFunction(i));
+  const valuesArray = [];
+  for (let i = 0; i < length; i++) {
+    valuesArray[i] = valueFunction(i);
+  }
+  return valuesArray;
 }
 
 

src/lib/core/style/focus-origin-monitor.spec.ts

@@ -131,7 +131,7 @@ describe('FocusOriginMonitor', () => {
   }));
 
   it('focusVia keyboard should simulate keyboard focus', async(() => {
-    focusOriginMonitor.focusVia(buttonElement, 'keyboard');
+    focusOriginMonitor.focusVia(buttonElement, buttonRenderer, 'keyboard');
     fixture.detectChanges();
 
     setTimeout(() => {
@@ -148,7 +148,7 @@ describe('FocusOriginMonitor', () => {
   }));
 
   it('focusVia mouse should simulate mouse focus', async(() => {
-    focusOriginMonitor.focusVia(buttonElement, 'mouse');
+    focusOriginMonitor.focusVia(buttonElement, buttonRenderer, 'mouse');
     fixture.detectChanges();
 
     setTimeout(() => {
@@ -165,7 +165,7 @@ describe('FocusOriginMonitor', () => {
   }));
 
   it('focusVia mouse should simulate mouse focus', async(() => {
-    focusOriginMonitor.focusVia(buttonElement, 'touch');
+    focusOriginMonitor.focusVia(buttonElement, buttonRenderer, 'touch');
     fixture.detectChanges();
 
     setTimeout(() => {
@@ -182,7 +182,7 @@ describe('FocusOriginMonitor', () => {
   }));
 
   it('focusVia program should simulate programmatic focus', async(() => {
-    focusOriginMonitor.focusVia(buttonElement, 'program');
+    focusOriginMonitor.focusVia(buttonElement, buttonRenderer, 'program');
     fixture.detectChanges();
 
     setTimeout(() => {

src/lib/radio/radio.spec.ts

@@ -143,7 +143,7 @@ describe('MdRadio', () => {
       expect(radioInstances[0].checked).toBe(false);
 
       let spies = radioInstances
-        .map((_value, index) => jasmine.createSpy(`onChangeSpy ${index}`));
+        .map((radio, index) => jasmine.createSpy(`onChangeSpy ${index} for ${radio.name}`));
 
       spies.forEach((spy, index) => radioInstances[index].change.subscribe(spy));
 

src/lib/radio/radio.ts

@@ -462,7 +462,7 @@ export class MdRadioButton implements OnInit, AfterViewInit, OnDestroy {
 
   /** Focuses the radio button. */
   focus(): void {
-    this._focusOriginMonitor.focusVia(this._inputElement.nativeElement, 'keyboard');
+    this._focusOriginMonitor.focusVia(this._inputElement.nativeElement, this._renderer, 'keyboard');
   }
 
   /**