Skip to content

Commit a6456a2

Browse files
crisbetokara
authored andcommitted
build: missing import in payload script (#5058)
1 parent 3eb7bdd commit a6456a2

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

tools/gulp/tasks/payload.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ import {statSync} from 'fs';
44
import {isTravisBuild, isTravisMasterBuild} from '../util/travis-ci';
55
import {buildConfig} from '../packaging/build-config';
66
import {openFirebaseDashboardApp, openFirebaseDashboardAppAsGuest} from '../util/firebase';
7+
import * as firebaseAdmin from 'firebase-admin';
8+
79

810
// These imports lack of type definitions.
911
const request = require('request');
@@ -66,7 +68,8 @@ function getFilesize(filePath: string) {
6668
* Calculates the difference between the last and current library payload.
6769
* The results will be published as a commit status on Github.
6870
*/
69-
async function calculatePayloadDiff(database: any, currentSha: string, currentPayload: any) {
71+
async function calculatePayloadDiff(database: firebaseAdmin.database.Database, currentSha: string,
72+
currentPayload: any) {
7073
const authToken = process.env['FIREBASE_ACCESS_TOKEN'];
7174

7275
if (!authToken) {
@@ -121,14 +124,15 @@ async function updateGithubStatus(commitSha: string, payloadDiff: number, authTo
121124
}
122125

123126
/** Uploads the current payload results to the Dashboard database. */
124-
async function uploadPayloadResults(database: any, currentSha: string, currentPayload: any) {
127+
async function uploadPayloadResults(database: firebaseAdmin.database.Database, currentSha: string,
128+
currentPayload: any) {
125129
if (isTravisMasterBuild()) {
126130
await database.ref('payloads').child(currentSha).set(currentPayload);
127131
}
128132
}
129133

130134
/** Gets the last payload uploaded from previous Travis builds. */
131-
async function getLastPayloadResults(database: admin.database.Database) {
135+
async function getLastPayloadResults(database: firebaseAdmin.database.Database) {
132136
const snapshot = await database.ref('payloads')
133137
.orderByChild('timestamp')
134138
.limitToLast(1)

tools/gulp/tasks/screenshots.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import {task} from 'gulp';
22
import {readdirSync, statSync, existsSync, mkdirp, readFileSync, writeFileSync} from 'fs-extra';
33
import * as path from 'path';
4-
import * as admin from 'firebase-admin';
4+
import * as firebaseAdmin from 'firebase-admin';
55
import * as firebase from 'firebase';
66
import {
77
openScreenshotsBucket,
@@ -55,7 +55,7 @@ function updateResult(database: firebase.database.Database, prNumber: string, re
5555
.child(process.env['TRAVIS_PULL_REQUEST_SHA']).set(result).then(() => result);
5656
}
5757

58-
function getPullRequestRef(database: firebase.database.Database | admin.database.Database,
58+
function getPullRequestRef(database: firebase.database.Database | firebaseAdmin.database.Database,
5959
prNumber: string) {
6060
let secureToken = getSecureToken();
6161
return database.ref(FIREBASE_REPORT).child(prNumber).child(secureToken);

0 commit comments

Comments
 (0)