feat: expand input types with coercion to work with ngtsc input type checking (#17528)

* feat: expand input types with coercion to work with ngtsc input type checking

* refactor: add workaround for strict metadata emit of coercion static members

See: angular/angular#33451

* build: patch ng_module bazel rule to enable strict template type checking

Workaround for: angular/angular#33452

* refactor: disable strict metadata emit for legacy build output

Workaround for angular/angular#33451. This makes
sense at the current time since the Bazel output does *never* work with
strict metadata emit... and considering that with Ivy there is no metadata
anyway, it could be disabled in the meanwhile.

* build: disable strict attribute type checking

We are temporarily disabling strict attribute type checking
since we have a few templates that set a coerced input while
the `NgModel` directive is applied. In those cases, the empty string
for the `disabled` input, is not assignable to the `NgModel#disabled` input,
since it does not do coercion. We need to figure out what to do in those
scenarios.

Author: devversion

src/a11y-demo/datepicker/datepicker-a11y.ts

@@ -31,5 +31,5 @@ export class DatepickerAccessibilityDemo {
   appointmentDate: Date;
   minAppointmentDate = new Date();
   maxAppointmentDate = new Date(Date.now() + 365 * 24 * 60 * 60 * 1000);
-  weekdaysOnly = (d: Date) => d.getDay() != 0 && d.getDay() != 6;
+  weekdaysOnly = (d: Date|null) => d !== null && d.getDay() != 0 && d.getDay() != 6;
 }

src/cdk-experimental/dialog/tsconfig-build.json

@@ -6,7 +6,6 @@
   ],
   "angularCompilerOptions": {
     "annotateForClosureCompiler": true,
-    "strictMetadataEmit": true,
     "flatModuleOutFile": "index.js",
     "flatModuleId": "@angular/cdk-experimental/dialog",
     "skipTemplateCodegen": true,

src/cdk-experimental/popover-edit/tsconfig-build.json

@@ -6,7 +6,6 @@
   ],
   "angularCompilerOptions": {
     "annotateForClosureCompiler": true,
-    "strictMetadataEmit": true,
     "flatModuleOutFile": "index.js",
     "flatModuleId": "@angular/cdk-experimental/popover-edit",
     "skipTemplateCodegen": true,

src/cdk-experimental/scrolling/auto-size-virtual-scroll.ts

@@ -463,4 +463,7 @@ export class CdkAutoSizeVirtualScroll implements OnChanges {
   ngOnChanges() {
     this._scrollStrategy.updateBufferSize(this.minBufferPx, this.maxBufferPx);
   }
+
+  static ngAcceptInputType_minBufferPx: number | string;
+  static ngAcceptInputType_maxBufferPx: number | string;
 }

src/cdk-experimental/scrolling/tsconfig-build.json

@@ -5,7 +5,6 @@
   ],
   "angularCompilerOptions": {
     "annotateForClosureCompiler": true,
-    "strictMetadataEmit": true,
     "flatModuleOutFile": "index.js",
     "flatModuleId": "@angular/cdk-experimental/scrolling",
     "skipTemplateCodegen": true,

src/cdk-experimental/tsconfig-build.json

@@ -24,7 +24,6 @@
   "angularCompilerOptions": {
     "enableIvy": false,
     "annotateForClosureCompiler": true,
-    "strictMetadataEmit": true,
     "flatModuleOutFile": "index.js",
     "flatModuleId": "@angular/cdk-experimental",
     "skipTemplateCodegen": true,

src/cdk-experimental/tsconfig-tests.json

@@ -14,7 +14,6 @@
     }
   },
   "angularCompilerOptions": {
-    "strictMetadataEmit": true,
     "skipTemplateCodegen": true,
     "emitDecoratorMetadata": true,
 

src/cdk/a11y/focus-trap/focus-trap.ts

@@ -418,4 +418,7 @@ export class CdkTrapFocus implements OnDestroy, AfterContentInit, DoCheck {
       this.focusTrap.attachAnchors();
     }
   }
+
+  static ngAcceptInputType_enabled: boolean | string;
+  static ngAcceptInputType_autoCapture: boolean | string;
 }

src/cdk/a11y/tsconfig-build.json

@@ -5,7 +5,6 @@
   ],
   "angularCompilerOptions": {
     "annotateForClosureCompiler": true,
-    "strictMetadataEmit": true,
     "flatModuleOutFile": "index.js",
     "flatModuleId": "@angular/cdk/a11y",
     "skipTemplateCodegen": true,

src/cdk/accordion/accordion-item.ts

@@ -152,4 +152,7 @@ export class CdkAccordionItem implements OnDestroy {
       }
     });
   }
+
+  static ngAcceptInputType_expanded: boolean | string;
+  static ngAcceptInputType_disabled: boolean | string;
 }