Skip to content

Commit 3067f8b

Browse files
committed
responding to feedback
1 parent 755cd7e commit 3067f8b

File tree

5 files changed

+11
-9
lines changed

5 files changed

+11
-9
lines changed

src/demo-app/tabs/tabs-demo.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
.md-tab-header {
1717
background: #f9f9f9;
1818
}
19-
md-tab-body {
19+
.md-tab-body-content {
2020
padding: 12px;
2121
}
2222
}

src/lib/tabs/_tabs-common.scss

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
$md-tab-bar-height: 48px !default;
44

5+
$md-tab-animation-duration: 500ms !default;
6+
57
// Mixin styles for labels that are contained within the tab header.
68
@mixin tab-label {
79
line-height: $md-tab-bar-height;
@@ -36,5 +38,5 @@ $md-tab-bar-height: 48px !default;
3638
position: absolute;
3739
bottom: 0;
3840
height: 2px;
39-
transition: 500ms ease-out;
40-
}
41+
transition: $md-tab-animation-duration $ease-in-out-curve-function;
42+
}

src/lib/tabs/tab-body.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@
33
(@position.start)="_onAnimationStarted($event)"
44
(@position.done)="_onAnimationComplete($event)">
55
<template portalHost></template>
6-
</div>
6+
</div>

src/lib/tabs/tab-group.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ md-ink-bar {
3333
position: relative;
3434
overflow: hidden;
3535
display: flex;
36-
transition: height 500ms $ease-in-out-curve-function;
36+
transition: height $md-tab-animation-duration $ease-in-out-curve-function;
3737
}
3838

3939
// Wraps each tab body

src/lib/tabs/tabs.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -300,10 +300,10 @@ export type MdTabBodyActiveState = 'left' | 'center' | 'right';
300300
templateUrl: 'tab-body.html',
301301
animations: [
302302
trigger('position', [
303-
state('left', style({transform: 'translateX(-100%)'})),
304-
state('center', style({transform: 'translateX(0%)'})),
305-
state('right', style({transform: 'translateX(100%)'})),
306-
transition('* => *', animate('0.5s cubic-bezier(0.35, 0, 0.25, 1)')),
303+
state('left', style({transform: 'translate3d(-100%, 0, 0)'})),
304+
state('center', style({transform: 'translate3d(0, 0, 0)'})),
305+
state('right', style({transform: 'translate3d(100%, 0, 0)'})),
306+
transition('* => *', animate('500ms cubic-bezier(0.35, 0, 0.25, 1)')),
307307
])
308308
]
309309
})

0 commit comments

Comments
 (0)