Skip to content

Commit 2b745c4

Browse files
crisbetommalerba
authored andcommitted
refactor(select): remove 6.0.0 deletion targets (#10163)
Removes the targets marked for 6.0.0 deletion from the `material/select` entry point. BREAKING CHANGES: * `onOpen`, which was deprecated in 5.0.0, has been removed. * `onClose`, which was deprecated in 5.0.0, has been removed. * `change`, which was deprecated in 5.0.0, has been removed.
1 parent 1a8106d commit 2b745c4

File tree

3 files changed

+7
-32
lines changed

3 files changed

+7
-32
lines changed

src/lib/paginator/paginator.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<mat-select
1111
[value]="pageSize"
1212
[aria-label]="_intl.itemsPerPageLabel"
13-
(change)="_changePageSize($event.value)">
13+
(selectionChange)="_changePageSize($event.value)">
1414
<mat-option *ngFor="let pageSizeOption of _displayedPageSizeOptions" [value]="pageSizeOption">
1515
{{pageSizeOption}}
1616
</mat-option>

src/lib/select/select.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2686,7 +2686,7 @@ describe('MatSelect', () => {
26862686
const spy = jasmine.createSpy('change spy');
26872687

26882688
fixture.detectChanges();
2689-
instance.select.change.subscribe(() => spy(instance.selectedFood));
2689+
instance.select.selectionChange.subscribe(() => spy(instance.selectedFood));
26902690

26912691
expect(instance.selectedFood).toBeFalsy();
26922692

src/lib/select/select.ts

Lines changed: 5 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -432,43 +432,18 @@ export class MatSelect extends _MatSelectMixinBase implements AfterContentInit,
432432
/** Event emitted when the select panel has been toggled. */
433433
@Output() readonly openedChange: EventEmitter<boolean> = new EventEmitter<boolean>();
434434

435-
/** Event emitted when the select has been opened. */
436-
@Output('opened')
437-
get _openedStream(): Observable<void> {
438-
return this.openedChange.pipe(filter(o => o), map(() => {}));
439-
}
435+
/** Event emitted when the select has been opened. */
436+
@Output('opened') readonly _openedStream: Observable<void> =
437+
this.openedChange.pipe(filter(o => o), map(() => {}));
440438

441439
/** Event emitted when the select has been closed. */
442-
@Output('closed')
443-
get _closedStream(): Observable<void> {
444-
return this.openedChange.pipe(filter(o => !o), map(() => {}));
445-
}
446-
447-
/**
448-
* Event emitted when the select has been opened.
449-
* @deprecated Use `openedChange` instead.
450-
* @deletion-target 6.0.0
451-
*/
452-
@Output() readonly onOpen: Observable<void> = this._openedStream;
453-
454-
/**
455-
* Event emitted when the select has been closed.
456-
* @deprecated Use `openedChange` instead.
457-
* @deletion-target 6.0.0
458-
*/
459-
@Output() readonly onClose: Observable<void> = this._closedStream;
440+
@Output('closed') readonly _closedStream: Observable<void> =
441+
this.openedChange.pipe(filter(o => !o), map(() => {}));
460442

461443
/** Event emitted when the selected value has been changed by the user. */
462444
@Output() readonly selectionChange: EventEmitter<MatSelectChange> =
463445
new EventEmitter<MatSelectChange>();
464446

465-
/**
466-
* Event emitted when the selected value has been changed by the user.
467-
* @deprecated Use `selectionChange` instead.
468-
* @deletion-target 6.0.0
469-
*/
470-
@Output() readonly change: EventEmitter<MatSelectChange> = this.selectionChange;
471-
472447
/**
473448
* Event that emits whenever the raw value of the select changes. This is here primarily
474449
* to facilitate the two-way binding for the `value` input.

0 commit comments

Comments
 (0)