fix(core): ErrorHandler should not rethrow an error by default (#15077)

[mhevery]

ErrorHandler can not throw errors because it will unsubscribe itself from
the error stream.

Zones captures errors and feed it into NgZone, which than has a Rx Observable
to feed it into ErrorHandler. If the ErroHandler throws, then Rx will teardown
the observable which in essence causes the ErrorHandler to be removed from the
error handling. This implies that the ErrorHandler can never throw errors.

Closes #14949
Closes #15182
Closes #14316

[chuckjaz]

You must leave @internal or you will break implementors of this class.

[chuckjaz]

Also the field is not deprecated, the parameter is.

[DzmitryShylovich]

I think you should overload the constructor and deprecate the one with parameter

[DzmitryShylovich]

@chuckjaz @mhevery btw IDE doesn't cross out constructor when parameter is deprecated:

class Test {
  constructor(/** @deprecated */ obj?: any) {
  }
}

new Test1(11); // everything is ok

but with constructor overload it does

class Test {
  constructor();
  /** @deprecated */
  constructor(obj: any);
  constructor(obj?: any) {
  }
}

new Test(11); // constructor is crossed out

[christianacca]

Unfortunately #14316 is not fixed by this PR

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}