fix(platform-server): setup NoopAnimationsModule in ServerModule by d…#15131
Closed
vikerman wants to merge 1 commit intoangular:masterfrom
vikerman:server-animation
Closed
fix(platform-server): setup NoopAnimationsModule in ServerModule by d…#15131vikerman wants to merge 1 commit intoangular:masterfrom vikerman:server-animation
vikerman wants to merge 1 commit intoangular:masterfrom
vikerman:server-animation
Conversation
alxhub
approved these changes
Mar 14, 2017
IgorMinar
approved these changes
Mar 17, 2017
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
…efault (angular#15131) This is so that server side rendering does not throw an exception when it encounters animations on the server side and does not need the user to explicitly setup NoopAnimationsModule in their app server module. Fixes angular#15098, angular#14784. PR Close angular#15131
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
…efault (angular#15131) This is so that server side rendering does not throw an exception when it encounters animations on the server side and does not need the user to explicitly setup NoopAnimationsModule in their app server module. Fixes angular#15098, angular#14784. PR Close angular#15131
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…efault
This is so that server side rendering does not throw an exception when it encounters animations on the server side and does not need the user to explicitly setup NoopAnimationsModule in their app server module.
Fixes #15098, #14784.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Server side rendering throws an exception even when using NoopAnimationsModule from app server module. The NoopAnimationsModule uses the DomRenderer by default and has to be routed through the ServerRenderer.
What is the new behavior?
NoopAnimationsModule is hooked up into ServerModule so that user does not have to do it themselves
Does this PR introduce a breaking change? (check one with "x")