[4.x] fix(core): stringify shouldn't throw when toString returns null/undefined#14975
Closed
DzmitryShylovich wants to merge 1 commit intoangular:masterfrom
Closed
[4.x] fix(core): stringify shouldn't throw when toString returns null/undefined#14975DzmitryShylovich wants to merge 1 commit intoangular:masterfrom
DzmitryShylovich wants to merge 1 commit intoangular:masterfrom
Conversation
vicb
reviewed
Mar 21, 2017
packages/core/test/util_spec.ts
Outdated
Contributor
There was a problem hiding this comment.
expect(stringify({toString => undefined})).toBe('undefined');
vicb
approved these changes
Mar 21, 2017
Contributor
vicb
left a comment
vicb
left a comment
There was a problem hiding this comment.
nit: could simplify the test
vicb
added
area: core
Contributor
Author
|
@vicb done. simplified the tests + rebase |
vicb
reviewed
Mar 21, 2017
packages/core/test/util_spec.ts
Outdated
Contributor
|
@DzmitryShylovich thanks ! Could you please update the return type |
Contributor
Author
|
@vicb done |
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14948