Skip to content

feat(compiler): do not parse xtb messages not needed by angular#14111

Closed
vicb wants to merge 1 commit intoangular:masterfrom
vicb:0125-invxtb
Closed

feat(compiler): do not parse xtb messages not needed by angular#14111
vicb wants to merge 1 commit intoangular:masterfrom
vicb:0125-invxtb

Conversation

@vicb
Copy link
Copy Markdown
Contributor

@vicb vicb commented Jan 26, 2017

fixes #14046

@vicb vicb added area: i18n Issues related to localization and internationalization action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 26, 2017
@vicb vicb changed the title feat(compiler): do not parse xtb messages not needed ny angular feat(compiler): do not parse xtb messages not needed by angular Jan 26, 2017
tbosch
tbosch reviewed Jan 26, 2017
View reviewed changes
modules/@angular/compiler/src/i18n/serializers/xtb.ts Outdated
Copy link
Copy Markdown
Contributor

@tbosch tbosch Jan 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pass a closure, and make this function generic.

tbosch
tbosch reviewed Jan 26, 2017
View reviewed changes
modules/@angular/compiler/test/i18n/serializers/xtb_spec.ts Outdated
Copy link
Copy Markdown
Contributor

@tbosch tbosch Jan 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<invalid-tag>...

@tbosch tbosch added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 26, 2017
@vicb vicb added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 26, 2017
@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Jan 27, 2017 •
edited
Loading

LGTM

Approved with PullApprove

@mhevery mhevery closed this in f7fba74 Jan 27, 2017
@vicb vicb deleted the 0125-invxtb branch February 16, 2017 18:57
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@vicb @juleskremer
feat(compiler): do not parse xtb messages not needed by angular (angu…
1113ee0 
…lar#14111)

fixes angular#14046

PR Close angular#14111
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@tbosch tbosch tbosch left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: i18n Issues related to localization and internationalization cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ngc translation merging chokes on messages (from other frameworks) that it can't parse

4 participants

@vicb @mhevery @tbosch @googlebot