fix(animations): generate aot code for animation trigger output events

[matsko]

No description provided.

[matsko]

@tbosch non jit code fails for animation integration tests.

Also, we now explose player within animations (which I think is a useful feature to have since it allows for users to get access to the player to pause and cancel the animation programmatically).

[matsko]

Aot Sample:

    _View_App0.prototype.detectChangesInternal = function(throwOnChange) {
        var self = this;
        var transitionAnimation = null ;
        var currVal_4 = self.context.openClose;
        if (jit_checkBinding6(throwOnChange, self._expr_4, currVal_4)) {
            var oldRenderVar = self._expr_4;
            if ((oldRenderVar == jit_UNINITIALIZED5) ) {
                (oldRenderVar = 'void');
            }
            var newRenderVar = currVal_4;
            if ((newRenderVar == jit_UNINITIALIZED5) ) {
                (newRenderVar = 'void');
            }
            transitionAnimation = self.componentType.animations['myTrigger'](self, self._el_8, oldRenderVar, newRenderVar);
            self._expr_4 = currVal_4;
        }
        if (transitionAnimation) {
            transitionAnimation.player.onDone(self.eventHandler(self._handle_myTrigger_8_0.bind(self, transitionAnimation)));
        }
        if (transitionAnimation) {
            transitionAnimation.player.onStart(self.eventHandler(self._handle_myTrigger_8_1.bind(self, transitionAnimation)));
        }
        self.detectContentChildrenChanges(throwOnChange);
        self.detectViewChildrenChanges(throwOnChange);
    }

[matsko]

main refactorings:

• generate events within onDone and onStart
• return only player from animation factory
• register inside of the if block

[matsko]

Codegen looks like this now:

_View_App0.prototype.detectChangesInternal = function(throwOnChange) {
    var self = this;
    var currVal_4 = self.context.openClose;
    if (jit_checkBinding6(throwOnChange, self._expr_4, currVal_4)) {
        var oldRenderVar = self._expr_4;
        if ((oldRenderVar == jit_UNINITIALIZED5) ) {
            (oldRenderVar = 'void');
        }
        var newRenderVar = currVal_4;
        if ((newRenderVar == jit_UNINITIALIZED5) ) {
            (newRenderVar = 'void');
        }
        var animationTransition_myTrigger = self.componentType.animations['myTrigger'](self, self._el_8, oldRenderVar, newRenderVar);
        animationTransition_myTrigger.onDone(self._handle_myTrigger_8_0.bind(self));
        animationTransition_myTrigger.onStart(self._handle_myTrigger_8_1.bind(self));
        self._expr_4 = currVal_4;
    }
    self.detectContentChildrenChanges(throwOnChange);
    self.detectViewChildrenChanges(throwOnChange);
};

[tbosch]

Remove the variables oldRenderVar and newRenderVar, and use a ternary expression instead.

...animationFnExpr.callFn([o.THIS_EXPR,
  oldRenderValue.equals(o.importExpr(resolveIdentifier(Identifiers.UNINITIALIZED))
    .conditional(oldRenderVar, emptyStateValue)),
  newRenderValue.equals(o.importExpr(resolveIdentifier(Identifiers.UNINITIALIZED))
    .conditional(newRenderVar, emptyStateValue)),
...

[tbosch]

This should be o.importType(resolveIdentifier(Identifiers.AnimationTransition)), as the factory returns an AnimationTransition, right?

[tbosch]

Not needed

[tbosch]

typo: allow them...

[tbosch]

remove _ prefix, and don't upper case everything. This is just a variable here, not a constant defined at the top leve.

[tbosch]

Move this further down, right before you declare the variable (as it is not used before that).

[tbosch]

Why are we always creating the animation again on view detach?

[tbosch]

this variable is not used any more.

[tbosch]

Use .callMethod(o.BuiltinMethod.Bind, ..., don't pass in bind as a string.

[tbosch]

Move the logic here into CompileEventListener.listenToAnimation.

[tbosch]

Why does the player need to be public?

[tbosch]

Don't use named arguments here, just positional ones and declare the fields as well. E.g.

constructor(private _player: AnimationPlayer, private _fromState: string, ...) {}

[tbosch]

Please ping @IgorMinar whether this is a breaking change, and we need to make this field optional. I don't expect users to new up their own AnimationTransitionEvent.

[tbosch]

why not private

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}