build: add @types/node to assorted locations where node types are being relied on and currently obtained transitively.

josephperrott · clydin · commit c2cbc0ffa624 · 2025-02-19T13:16:03.000-05:00
diff --git a/modules/testing/builder/BUILD.bazel b/modules/testing/builder/BUILD.bazel
@@ -24,6 +24,7 @@ ts_project(
     deps = [
         ":node_modules/@angular-devkit/architect",
         ":node_modules/@angular-devkit/core",
+        "//:node_modules/@types/node",
         "//:node_modules/rxjs",
     ],
 )
diff --git a/packages/angular/pwa/BUILD.bazel b/packages/angular/pwa/BUILD.bazel
@@ -53,6 +53,7 @@ ts_project(
     deps = [
         ":pwa_rjs",
         "//:node_modules/@types/jasmine",
+        "//:node_modules/@types/node",
         "//packages/angular_devkit/schematics/testing:testing_rjs",
     ],
 )
diff --git a/packages/angular/ssr/node/test/BUILD.bazel b/packages/angular/ssr/node/test/BUILD.bazel
@@ -7,6 +7,7 @@ ts_project(
     testonly = True,
     srcs = glob(["**/*_spec.ts"]),
     deps = [
+        "//:node_modules/@types/node",
         "//packages/angular/ssr/node:node_rjs",
     ],
 )
diff --git a/packages/angular/ssr/schematics/BUILD.bazel b/packages/angular/ssr/schematics/BUILD.bazel
@@ -80,6 +80,7 @@ ts_project(
     ),
     deps = [
         ":schematics_rjs",
+        "//:node_modules/@types/node",
         "//packages/angular_devkit/schematics/testing:testing_rjs",
     ],
 )
diff --git a/packages/angular/ssr/test/BUILD.bazel b/packages/angular/ssr/test/BUILD.bazel
@@ -15,6 +15,7 @@ ts_project(
         "//:node_modules/@angular/platform-browser",
         "//:node_modules/@angular/platform-server",
         "//:node_modules/@angular/router",
+        "//:node_modules/@types/node",
         "//packages/angular/ssr:ssr_rjs",
     ],
 )
diff --git a/packages/angular/ssr/test/npm_package/BUILD.bazel b/packages/angular/ssr/test/npm_package/BUILD.bazel
@@ -9,6 +9,7 @@ ts_project(
     srcs = glob(["**/*.ts"]),
     deps = [
         "//:node_modules/@bazel/runfiles",
+        "//:node_modules/@types/node",
     ],
 )
 
diff --git a/packages/angular_devkit/architect/BUILD.bazel b/packages/angular_devkit/architect/BUILD.bazel
@@ -82,6 +82,7 @@ ts_project(
         ":architect_rjs",
         ":node_modules/@angular-devkit/core",
         "//:node_modules/@types/jasmine",
+        "//:node_modules/@types/node",
         "//:node_modules/rxjs",
         "//packages/angular_devkit/architect/testing:testing_rjs",
     ],
diff --git a/packages/angular_devkit/architect/node/BUILD.bazel b/packages/angular_devkit/architect/node/BUILD.bazel
@@ -35,6 +35,7 @@ ts_project(
     deps = [
         ":node_rjs",
         "//:node_modules/@types/jasmine",
+        "//:node_modules/@types/node",
         "//:node_modules/rxjs",
         "//packages/angular_devkit/architect:architect_rjs",
         "//packages/angular_devkit/architect/node/test:test_lib_rjs",
diff --git a/packages/angular_devkit/architect_cli/BUILD.bazel b/packages/angular_devkit/architect_cli/BUILD.bazel
@@ -20,10 +20,12 @@ ts_project(
     deps = [
         ":node_modules/@angular-devkit/architect",
         ":node_modules/@angular-devkit/core",
+        ":node_modules/progress",
         "//:node_modules/@types/node",
         "//:node_modules/@types/progress",
         "//:node_modules/@types/yargs-parser",
         "//:node_modules/ansi-colors",
+        "//:node_modules/yargs-parser",
     ],
 )
 
diff --git a/packages/angular_devkit/build_webpack/BUILD.bazel b/packages/angular_devkit/build_webpack/BUILD.bazel
@@ -74,6 +74,7 @@ ts_project(
         ":node_modules/@angular-devkit/core",
         ":node_modules/@ngtools/webpack",
         "//:node_modules/@types/jasmine",
+        "//:node_modules/@types/node",
     ],
 )
 
diff --git a/packages/angular_devkit/core/BUILD.bazel b/packages/angular_devkit/core/BUILD.bazel
@@ -54,6 +54,7 @@ ts_project(
     data = glob(["src/workspace/json/test/**/*.json"]),
     deps = [
         ":core_rjs",
+        "//:node_modules/@types/node",
         "//:node_modules/rxjs",
         "//packages/angular_devkit/core/node:node_rjs",
     ],
diff --git a/packages/angular_devkit/core/node/BUILD.bazel b/packages/angular_devkit/core/node/BUILD.bazel
@@ -41,6 +41,7 @@ ts_project(
     deps = [
         ":node_rjs",
         "//:node_modules/@types/jasmine",
+        "//:node_modules/@types/node",
         "//:node_modules/rxjs",
         "//packages/angular_devkit/core:core_rjs",
     ],
diff --git a/packages/angular_devkit/schematics/tools/BUILD.bazel b/packages/angular_devkit/schematics/tools/BUILD.bazel
@@ -42,6 +42,7 @@ ts_project(
     deps = [
         ":tools_rjs",
         "//:node_modules/@types/jasmine",
+        "//:node_modules/@types/node",
         "//:node_modules/rxjs",
         "//packages/angular_devkit/schematics:node_modules/@angular-devkit/core",
         "//packages/angular_devkit/schematics:schematics_rjs",
diff --git a/packages/schematics/angular/BUILD.bazel b/packages/schematics/angular/BUILD.bazel
@@ -120,6 +120,7 @@ ts_project(
         ":node_modules/@angular-devkit/core",
         ":node_modules/@angular-devkit/schematics",
         "//:node_modules/@types/jasmine",
+        "//:node_modules/@types/node",
         "//:node_modules/jsonc-parser",
         "//packages/schematics/angular/third_party/github.com/Microsoft/TypeScript:TypeScript_rjs",
     ],
diff --git a/tests/legacy-cli/BUILD.bazel b/tests/legacy-cli/BUILD.bazel
@@ -12,6 +12,7 @@ ts_project(
         "verdaccio_auth.yaml",
     ],
     deps = [
+        "//:node_modules/@types/node",
         "//:node_modules/ansi-colors",
         "//:node_modules/fast-glob",
         "//packages/angular_devkit/core:core_rjs",
diff --git a/tests/legacy-cli/e2e/initialize/BUILD.bazel b/tests/legacy-cli/e2e/initialize/BUILD.bazel
@@ -10,6 +10,7 @@ ts_project(
         "//:config-files",
     ],
     deps = [
+        "//:node_modules/@types/node",
         "//tests/legacy-cli/e2e/utils:utils_rjs",
     ],
 )
diff --git a/tests/legacy-cli/e2e/setup/BUILD.bazel b/tests/legacy-cli/e2e/setup/BUILD.bazel
@@ -7,6 +7,7 @@ ts_project(
     testonly = True,
     srcs = glob(["**/*.ts"]),
     deps = [
+        "//:node_modules/@types/node",
         "//tests/legacy-cli/e2e/utils:utils_rjs",
     ],
 )
diff --git a/tests/legacy-cli/e2e/tests/BUILD.bazel b/tests/legacy-cli/e2e/tests/BUILD.bazel
@@ -11,6 +11,7 @@ ts_project(
     ],
     deps = [
         "//:node_modules/@types/express",
+        "//:node_modules/@types/node",
         "//:node_modules/@types/semver",
         "//:node_modules/express",
         "//:node_modules/fast-glob",
diff --git a/tests/legacy-cli/e2e/utils/BUILD.bazel b/tests/legacy-cli/e2e/utils/BUILD.bazel
@@ -11,6 +11,7 @@ ts_project(
     ],
     deps = [
         "//:node_modules/@types/jasmine",
+        "//:node_modules/@types/node",
         "//:node_modules/@types/semver",
         "//:node_modules/ansi-colors",
         "//:node_modules/fast-glob",

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@ ts_project(`
`24`	`24`	`deps = [`
`25`	`25`	`":node_modules/@angular-devkit/architect",`
`26`	`26`	`":node_modules/@angular-devkit/core",`
	`27`	`+ "//:node_modules/@types/node",`
`27`	`28`	`"//:node_modules/rxjs",`
`28`	`29`	`],`
`29`	`30`	`)`
Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,7 @@ ts_project(`
`53`	`53`	`deps = [`
`54`	`54`	`":pwa_rjs",`
`55`	`55`	`"//:node_modules/@types/jasmine",`
	`56`	`+ "//:node_modules/@types/node",`
`56`	`57`	`"//packages/angular_devkit/schematics/testing:testing_rjs",`
`57`	`58`	`],`
`58`	`59`	`)`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@ ts_project(`
`7`	`7`	`testonly = True,`
`8`	`8`	`srcs = glob(["*/_spec.ts"]),`
`9`	`9`	`deps = [`
	`10`	`+ "//:node_modules/@types/node",`
`10`	`11`	`"//packages/angular/ssr/node:node_rjs",`
`11`	`12`	`],`
`12`	`13`	`)`
Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,7 @@ ts_project(`
`80`	`80`	`),`
`81`	`81`	`deps = [`
`82`	`82`	`":schematics_rjs",`
	`83`	`+ "//:node_modules/@types/node",`
`83`	`84`	`"//packages/angular_devkit/schematics/testing:testing_rjs",`
`84`	`85`	`],`
`85`	`86`	`)`
Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@ ts_project(`
`15`	`15`	`"//:node_modules/@angular/platform-browser",`
`16`	`16`	`"//:node_modules/@angular/platform-server",`
`17`	`17`	`"//:node_modules/@angular/router",`
	`18`	`+ "//:node_modules/@types/node",`
`18`	`19`	`"//packages/angular/ssr:ssr_rjs",`
`19`	`20`	`],`
`20`	`21`	`)`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@ ts_project(`
`9`	`9`	`srcs = glob(["*/.ts"]),`
`10`	`10`	`deps = [`
`11`	`11`	`"//:node_modules/@bazel/runfiles",`
	`12`	`+ "//:node_modules/@types/node",`
`12`	`13`	`],`
`13`	`14`	`)`
`14`	`15`
Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,7 @@ ts_project(`
`74`	`74`	`":node_modules/@angular-devkit/core",`
`75`	`75`	`":node_modules/@ngtools/webpack",`
`76`	`76`	`"//:node_modules/@types/jasmine",`
	`77`	`+ "//:node_modules/@types/node",`
`77`	`78`	`],`
`78`	`79`	`)`
`79`	`80`