Mark function completion items as snippets

andrewbraxton · andrewbraxton · commit 3e0d1df77740 · 2025-01-02T23:23:45.000-05:00
The PR LuaLS#3005 assumed that all snippets were setting `insertTextFormat` to 2 and leaving plaintext completions nil, but that was not the case. Function completions need to be marked as snippets too. fixes LuaLS#3021
diff --git a/script/core/completion/completion.lua b/script/core/completion/completion.lua
@@ -1351,6 +1351,7 @@ local function insertEnum(state, pos, src, enums, isInArray, mark)
             description = description,
             kind        = define.CompletionItemKind.Function,
             insertText  = insertText,
+            insertTextFormat = 2,
         }
     elseif src.type == 'doc.enum' then
         ---@cast src parser.object

Original file line number	Diff line number	Diff line change
`@@ -1351,6 +1351,7 @@ local function insertEnum(state, pos, src, enums, isInArray, mark)`
`1351`	`1351`	`description = description,`
`1352`	`1352`	`kind = define.CompletionItemKind.Function,`
`1353`	`1353`	`insertText = insertText,`
	`1354`	`+ insertTextFormat = 2,`
`1354`	`1355`	`}`
`1355`	`1356`	`elseif src.type == 'doc.enum' then`
`1356`	`1357`	`---@cast src parser.object`