Skip to content

Commit 632d614

Browse files
Christoph Hellwiggregkh
authored andcommitted
nvme-pci: disable namespace identifiers for Qemu controllers
[ Upstream commit 66dd346 ] Qemu unconditionally reports a UUID, which depending on the qemu version is either all-null (which is incorrect but harmless) or contains a single bit set for all controllers. In addition it can also optionally report a eui64 which needs to be manually set. Disable namespace identifiers for Qemu controlles entirely even if in some cases they could be set correctly through manual intervention. Reported-by: Luis Chamberlain <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]> Reviewed-by: Keith Busch <[email protected]> Reviewed-by: Sagi Grimberg <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
1 parent e2368e4 commit 632d614

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/nvme/host/pci.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3405,7 +3405,10 @@ static const struct pci_device_id nvme_id_table[] = {
34053405
.driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN, },
34063406
{ PCI_VDEVICE(INTEL, 0x5845), /* Qemu emulated controller */
34073407
.driver_data = NVME_QUIRK_IDENTIFY_CNS |
3408-
NVME_QUIRK_DISABLE_WRITE_ZEROES, },
3408+
NVME_QUIRK_DISABLE_WRITE_ZEROES |
3409+
NVME_QUIRK_BOGUS_NID, },
3410+
{ PCI_VDEVICE(REDHAT, 0x0010), /* Qemu emulated controller */
3411+
.driver_data = NVME_QUIRK_BOGUS_NID, },
34093412
{ PCI_DEVICE(0x126f, 0x2263), /* Silicon Motion unidentified */
34103413
.driver_data = NVME_QUIRK_NO_NS_DESC_LIST, },
34113414
{ PCI_DEVICE(0x1bb1, 0x0100), /* Seagate Nytro Flash Storage */

0 commit comments

Comments
 (0)