Applied early exit on is_writable_path().

Author: allinurl

src/options.c

@@ -833,8 +833,8 @@ read_option_args (int argc, char **argv) {
     case 'o':
       if (!valid_output_type (optarg))
         FATAL ("Invalid filename extension. It must be any of .csv, .json, or .html\n");
-        if (!is_writable_path(optarg))
-          FATAL("Invalid or unwritable path.");
+      if (!is_writable_path (optarg))
+        FATAL ("Invalid or unwritable path.");
       if (conf.output_format_idx < MAX_OUTFORMATS)
         conf.output_formats[conf.output_format_idx++] = optarg;
       break;

src/util.c

@@ -1225,22 +1225,22 @@ unescape_str (const char *src) {
 
 int
 is_writable_path (const char *path) {
-  if (access (path, W_OK) == 0) {
-    return 1;   // Path is writable
-  } else {
-    switch (errno) {
-    case ENOENT:
-      fprintf (stderr, "Path does not exist: %s\n", path);
-      return 0;
-    case EACCES:
-      fprintf (stderr, "No write permission for path: %s\n", path);
-      return 0;
-    case EROFS:
-      fprintf (stderr, "Path is on a read-only file system: %s\n", path);
-      return 0;
-    default:
-      fprintf (stderr, "Unknown error (errno %d) for path: %s\n", errno, path);
-      return 0;
-    }
+  /* Path is writable */
+  if (access (path, W_OK) == 0)
+    return 1;
+
+  switch (errno) {
+  case ENOENT:
+    fprintf (stderr, "Path does not exist: %s\n", path);
+    return 0;
+  case EACCES:
+    fprintf (stderr, "No write permission for path: %s\n", path);
+    return 0;
+  case EROFS:
+    fprintf (stderr, "Path is on a read-only file system: %s\n", path);
+    return 0;
+  default:
+    fprintf (stderr, "Unknown error (errno %d) for path: %s\n", errno, path);
+    return 0;
   }
 }