Fine tune priority values for visualisation resolvers so Grid would be preffered over BarChart (#893)

adrianmroz-allegro · web-flow · commit 9c251d5feaf3 · 2022-04-11T16:28:24.000+02:00
diff --git a/src/common/visualization-manifests/bar-chart/bar-chart.ts b/src/common/visualization-manifests/bar-chart/bar-chart.ts
@@ -105,7 +105,7 @@ const rulesEvaluator = visualizationDependentEvaluatorBuilder
       return Resolve.automatic(5 + continuousBoost, { splits: newSplits });
     }
 
-    return Resolve.ready(isSelectedVisualization ? 10 : 7 + continuousBoost);
+    return Resolve.ready(isSelectedVisualization ? 10 : 6 + continuousBoost);
   })
 
   .otherwise(({ dataCube }) => {
diff --git a/src/common/visualization-manifests/grid/grid.ts b/src/common/visualization-manifests/grid/grid.ts
@@ -45,7 +45,7 @@ const rulesEvaluator = visualizationDependentEvaluatorBuilder
     const newSplits = splits.replace(firstSplit, fixedFirstSplit);
 
     if (splits.equals(newSplits)) {
-      return Resolve.ready(isSelectedVisualization ? 10 : 4);
+      return Resolve.ready(isSelectedVisualization ? 10 : 6);
     }
     return Resolve.automatic(6, { splits: newSplits });
   })

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ const rulesEvaluator = visualizationDependentEvaluatorBuilder`
`105`	`105`	`return Resolve.automatic(5 + continuousBoost, { splits: newSplits });`
`106`	`106`	`}`
`107`	`107`
`108`		`- return Resolve.ready(isSelectedVisualization ? 10 : 7 + continuousBoost);`
	`108`	`+ return Resolve.ready(isSelectedVisualization ? 10 : 6 + continuousBoost);`
`109`	`109`	`})`
`110`	`110`
`111`	`111`	`.otherwise(({ dataCube }) => {`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ const rulesEvaluator = visualizationDependentEvaluatorBuilder`
`45`	`45`	`const newSplits = splits.replace(firstSplit, fixedFirstSplit);`
`46`	`46`
`47`	`47`	`if (splits.equals(newSplits)) {`
`48`		`- return Resolve.ready(isSelectedVisualization ? 10 : 4);`
	`48`	`+ return Resolve.ready(isSelectedVisualization ? 10 : 6);`
`49`	`49`	`}`
`50`	`50`	`return Resolve.automatic(6, { splits: newSplits });`
`51`	`51`	`})`