Skip to content

fix: ability to pass kw_only flag to dataclass when defining struct subclass #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 3, 2024
Merged

fix: ability to pass kw_only flag to dataclass when defining struct subclass #23

merged 3 commits into from
Sep 3, 2024

Conversation

aorumbayev
Copy link
Contributor

@aorumbayev aorumbayev commented Sep 2, 2024 •
edited
Loading

Proposed Changes

  • Reported by Giorgio, passing kw_only flag to definition of Struct subclass was not recognized by the testing implementation
  • Minor addition of dependabot.yaml used across other algokit python projects

@CiottiGiorgio CiottiGiorgio mentioned this pull request Sep 2, 2024
Closed
daniel-makerx
daniel-makerx reviewed Sep 3, 2024
View reviewed changes
@aorumbayev aorumbayev merged commit 24bcf9d into main Sep 3, 2024
1 check passed
@aorumbayev aorumbayev deleted the fix/kw-only-structs branch September 3, 2024 07:20
@aorumbayev
Copy link
Contributor Author

fixes #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-makerx daniel-makerx daniel-makerx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aorumbayev @daniel-makerx